Repeating rounding errors with svg:viewBox, svg:d & friends

Hi, is anyone currently looking into improving graph data handling? Because things are slightly screwed there IMHO. E.g. I was trying to fix EnhancedPathShape::saveOdf(...), which is currently saving non-integer data for "svg:viewBox", by code like context.xmlWriter().addAttribute("svg

Re: Review Request: Fix Bug 303003 - koreport: page sizes are not internationalized

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105469/#review15532 --- libs/koreport/wrtembed/KoReportDesigner.h

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 8:36 a.m., C. Boemann wrote: > > building gives me this error > > > > /home/cbo/devel/calligra/kexi/migration/keximigratedata.h:25:27: fatal > > error: db/connection.h: No such file or directory > > Jarosław Staniek wrote: > Please make sure you have the full patch. Have

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 9:07 a.m., Boudewijn Rempt wrote: > > I guess this is because the bibliography stuff is going to use it? In any > > case, before moving a lot of code into libs, I would like to see that it > > uses the calligra coding style in matters of file names (KoConnection.cpp > > inst

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 9:07 a.m., Boudewijn Rempt wrote: > > I guess this is because the bibliography stuff is going to use it? In any > > case, before moving a lot of code into libs, I would like to see that it > > uses the calligra coding style in matters of file names (KoConnection.cpp > > inst

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 9:07 a.m., Boudewijn Rempt wrote: > > I guess this is because the bibliography stuff is going to use it? In any > > case, before moving a lot of code into libs, I would like to see that it > > uses the calligra coding style in matters of file names (KoConnection.cpp > > inst

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 8:36 a.m., C. Boemann wrote: > > building gives me this error > > > > /home/cbo/devel/calligra/kexi/migration/keximigratedata.h:25:27: fatal > > error: db/connection.h: No such file or directory > > Jarosław Staniek wrote: > Please make sure you have the full patch. Have

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 9:07 a.m., Boudewijn Rempt wrote: > > I guess this is because the bibliography stuff is going to use it? In any > > case, before moving a lot of code into libs, I would like to see that it > > uses the calligra coding style in matters of file names (KoConnection.cpp > > inst

Re: Review Request: fix writing of text:time values

> On July 7, 2012, 4:50 p.m., Pierre Stirnweiss wrote: > > plugins/variables/DateVariable.cpp, line 126 > > > > > > Won't this create a round-trip problem? > > The loaded file haven't got a date. On saving it wi

Re: Review Request: fix writing of text:time values

> On July 7, 2012, 4:50 p.m., Pierre Stirnweiss wrote: > > plugins/variables/DateVariable.cpp, line 126 > > > > > > Won't this create a round-trip problem? > > The loaded file haven't got a date. On saving it wi

Re: Review Request: fix writing of text:time values

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463/#review15518 --- plugins/variables/DateVariable.cpp

Re: On master remove your calligrathumbnail.desktop from the installation

Two more notes: Yes, there are no thumbnails created for xfig and wmf files yet, because the kdelibs thumbnail system just picks the first in the list of thumbnail creators which claim support for a type, and sadly the plain image thumbnail creator coming with kde-runtime does that for both typ

On master remove your calligrathumbnail.desktop from the installation (was: Re: [calligra] /: pimp the thumbnailer)

Hi Calligra-heads, if you update to latest master, please make sure that you rm calligrathumbnail.desktop from $(YOUR_INSTALL_BASE)/share/kde4/services/ so you get the full joy of the pimped calligra thumbnailer(s). Also clean your ~/.thumbnails to get rid of the cached thumbnails. Then take a loo

Re: Review Request: make Calligra thumbnailer functional again

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105373/#review15514 --- This review has been submitted with commit ca51fcfc7b51480da36

Re: Review Request: Cursor width must be multiple of 16 on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105472/#review15512 --- Ship it! Awesome, many thanks! - Boudewijn Rempt On July 7,

Re: Review Request: make Calligra thumbnailer functional again

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105373/#review15511 --- Ship it! Ship It! - Boudewijn Rempt On July 4, 2012, 1:08 p

Re: Review Request: add command for undo/redo change in chart type

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105470/#review15509 --- Ship it! Looks fine. Ship it! - Inge Wallin On July 7, 201

Re: Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105471/#review15508 --- This review has been submitted with commit 3696eccc1cdcf917597

Re: Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105471/#review15507 --- This review has been submitted with commit de494d6c7e14981759e

Re: Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105471/#review15506 --- Ship it! Marijn is on vacation, and given the simple patch and

Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105471/ --- Review request for Calligra and Marijn Kruisselbrink. Description ---

Review Request: add command for undo/redo change in chart type

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105470/ --- Review request for Calligra and Inge Wallin. Description --- some cha

Re: Review Request: make Calligra thumbnailer functional again

> On July 7, 2012, 10:04 a.m., Boudewijn Rempt wrote: > > Maybe I did something wrong, but after building and installing everything, > > I still have badges in .kra and .ora files that I just created. Could be for two reasons (hopefully): 1. the old thumbnail kio-slave was still running with th

Re: Review Request: fix writing of text:time values

> On July 7, 2012, 4:06 a.m., Thorsten Zachmann wrote: > > plugins/variables/DateVariable.cpp, lines 113-114 > > > > > > I think we should keep this workaround as calligra saved out this wrong > > value. Maybe put

Re: Review Request: fix writing of text:time values

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463/ --- (Updated July 7, 2012, 10:16 a.m.) Review request for Calligra and Thorste

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 9:07 a.m., Boudewijn Rempt wrote: > > I guess this is because the bibliography stuff is going to use it? In any > > case, before moving a lot of code into libs, I would like to see that it > > uses the calligra coding style in matters of file names (KoConnection.cpp > > inst

Re: Review Request: make Calligra thumbnailer functional again

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105373/#review15500 --- Maybe I did something wrong, but after building and installing

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 8:36 a.m., C. Boemann wrote: > > building gives me this error > > > > /home/cbo/devel/calligra/kexi/migration/keximigratedata.h:25:27: fatal > > error: db/connection.h: No such file or directory > > Jarosław Staniek wrote: > Please make sure you have the full patch. Have

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 9:07 a.m., Boudewijn Rempt wrote: > > I guess this is because the bibliography stuff is going to use it? In any > > case, before moving a lot of code into libs, I would like to see that it > > uses the calligra coding style in matters of file names (KoConnection.cpp > > inst

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105464/#review15497 --- I guess this is because the bibliography stuff is going to use

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 8:36 a.m., C. Boemann wrote: > > building gives me this error > > > > /home/cbo/devel/calligra/kexi/migration/keximigratedata.h:25:27: fatal > > error: db/connection.h: No such file or directory Please make sure you have the full patch. Have you used the kexi-calligradb-sta

Re: Review Request: KoPageFormat: add getter for list of non-localized page sizes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105434/#review15496 --- This review has been submitted with commit 4b748ea1e27b7e07057

Review Request: Fix Bug 303003 - koreport: page sizes are not internationalized

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105469/ --- Review request for Calligra, Jarosław Staniek and Adam Pigg. Description -

Re: Review Request: KoPageFormat: add getter for list of non-localized page sizes

> On July 6, 2012, 8:52 p.m., Jarosław Staniek wrote: > > libs/odf/KoPageFormat.cpp, line 168 > > > > > > --> > > QStringList KoPageFormat::allShortNames() const This is not a class, just a namespace. - Dag

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105464/#review15492 --- building gives me this error /home/cbo/devel/calligra/kexi/mig

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

> On July 7, 2012, 6:11 a.m., C. Boemann wrote: > > CMakeLists.txt, line 180 > > > > > > should probably say something more than just kexi then Fixed. - Jarosław