Re: Review Request: Add unit test of report page options

2012-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105411/#review15324 --- This review has been submitted with commit 07928e19cf8c50cf1f2

Re: [PATCH] make KoDocument::nativeFormatMimeType() non-virtual

2012-07-02 Thread Friedrich W. H. Kossebau
Am Dienstag, 3. Juli 2012, 07:39:50 schrieb C. Boemann: > On Sunday 01 July 2012 19:05:20 Friedrich W. H. Kossebau wrote: > > Hi, > > > > another little clean-up-which-would-be-quicker-to-do-on-irc-but-async- > > communication-saves-me. > > The kounavail part has gone, so virtual and the comment a

Re: [PATCH] make KoDocument::nativeFormatMimeType() non-virtual

2012-07-02 Thread C. Boemann
On Sunday 01 July 2012 19:05:20 Friedrich W. H. Kossebau wrote: > Hi, > > another little clean-up-which-would-be-quicker-to-do-on-irc-but-async- > communication-saves-me. > The kounavail part has gone, so virtual and the comment are no longer > needed. > > Okay to commit to master? > > @Boud: If

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/ --- (Updated July 2, 2012, 8:47 p.m.) Review request for Calligra and Jarosław

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15321 --- OK, so far everything is right, just the missing bits marked wi

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Adam Pigg
> On July 2, 2012, 8:04 p.m., Jarosław Staniek wrote: > > kexi/plugins/tables/kexitabledesignerview.cpp, line 1130 > > > > > > why is this line removed? Because it is not needed. In the lines above, the setPrimar

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15318 --- kexi/plugins/tables/kexitabledesignerview.cpp

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/ --- (Updated July 2, 2012, 7:42 p.m.) Review request for Calligra and Jarosław

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 18:15:10 schrieb Friedrich W. H. Kossebau: > Investigating... And think I found the reason. See comment on bug. Cheers Friedrich ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/callig

Re: Review Request: Port tables plugin to QUndo/kundo2

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105366/#review15315 --- kexi/plugins/tables/kexitabledesignerview.cpp

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 17:34:07 schrieb Friedrich W. H. Kossebau: > Am Montag, 2. Juli 2012, 16:58:10 schrieb David Revoy: > > Hi Friedrich, > > > > (bug :https://bugs.kde.org/show_bug.cgi?id=290875 ) > > On the screenshot > > (http://img861.imageshack.us/img861/7954/20120107screenshot01.jpg

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 16:58:10 schrieb David Revoy: > Hi Friedrich, > > (bug :https://bugs.kde.org/show_bug.cgi?id=290875 ) > On the screenshot > (http://img861.imageshack.us/img861/7954/20120107screenshot01.jpg ) the > one without the blendicon are *.ora files saved by Mypaint. Mypaint have

Re: Review Request: Add unit test of report page options

2012-07-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105411/#review15313 --- Ship it! Brilliant! Good job, Dag! libs/koreport/tests/KoRep

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread David Revoy
Hi Friedrich, (bug :https://bugs.kde.org/show_bug.cgi?id=290875 ) On the screenshot (http://img861.imageshack.us/img861/7954/20120107screenshot01.jpg ) the one without the blendicon are *.ora files saved by Mypaint. Mypaint have it's own *.ora writer, and generate the thumbnail inside the *

Review Request: Add unit test of report page options

2012-07-02 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105411/ --- Review request for Calligra, Jarosław Staniek and Adam Pigg. Description -

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105390/#review15311 --- This review has been submitted with commit 529469a23cf9d1ffbe8

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105390/#review15310 --- This review has been submitted with commit 7cc2db4a51ecd91cb87

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Hi Boudewijn, Am Montag, 2. Juli 2012, 08:13:13 schrieb Boudewijn Rempt: > Friedrich, > > Could this regression be because of your thumbnailer work? We don't want the > icon to show up for .kra or .ora documents. There is not yet any commit merged from me to the thumbnailer plugin, so I feel in