Re: Review Request: Fix bug 246898: Take opacity into consideration while drawing venn diagrams

2012-06-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105301/#review15053 --- Ship it! Nice work. libs/flake/KoGradientBackground.cpp

Re: Review Request: KoReport: fix save/load page margins

2012-06-23 Thread Jarosław Staniek
> On June 22, 2012, 8:40 p.m., Adam Pigg wrote: > > The only thing that bothers me slightly is that all other geometry is saved > > in user units, such as CM, but this simplifies it slightly and works, so it > > should be ok. So how does it look like after this patch applied? I'd like to see a

Re: Review Request: Bibliography database UI

2012-06-23 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review15049 --- I tested your branch today. First of all thanks for the nice wo

Re: Review Request: Porting KexiCVSImportDialog

2012-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105302/#review15044 --- This review has been submitted with commit 6f33d78f0c562f63351

Re: Announcement written, needs proof reading and screenshot

2012-06-23 Thread C. Boemann
On Saturday 23 June 2012 16:14:15 Jaroslaw Staniek wrote: > On 23 June 2012 16:02, C. Boemann wrote: > > On Saturday 23 June 2012 15:57:20 Jaroslaw Staniek wrote: > >> On 23 June 2012 15:53, Jaroslaw Staniek wrote: > >> > On 23 June 2012 09:39, Inge Wallin wrote: > >> >> I have written the annou

Re: Announcement written, needs proof reading and screenshot

2012-06-23 Thread Jaroslaw Staniek
On 23 June 2012 16:02, C. Boemann wrote: > On Saturday 23 June 2012 15:57:20 Jaroslaw Staniek wrote: >> On 23 June 2012 15:53, Jaroslaw Staniek wrote: >> > On 23 June 2012 09:39, Inge Wallin wrote: >> >> I have written the announcement of 2.5beta, but it still needs >> >> proofreading. >> >> >>

Re: Announcement written, needs proof reading and screenshot

2012-06-23 Thread C. Boemann
On Saturday 23 June 2012 15:57:20 Jaroslaw Staniek wrote: > On 23 June 2012 15:53, Jaroslaw Staniek wrote: > > On 23 June 2012 09:39, Inge Wallin wrote: > >> I have written the announcement of 2.5beta, but it still needs > >> proofreading. > >> > >> It would also be good if somebody could add a

Re: Announcement written, needs proof reading and screenshot

2012-06-23 Thread Jaroslaw Staniek
On 23 June 2012 15:53, Jaroslaw Staniek wrote: > On 23 June 2012 09:39, Inge Wallin wrote: >> I have written the announcement of 2.5beta, but it still needs proofreading. >> >> It would also be good if somebody could add a screenshot of the new cell >> editor and cell tool in sheets and maybe als

Re: Announcement written, needs proof reading and screenshot

2012-06-23 Thread Jaroslaw Staniek
On 23 June 2012 09:39, Inge Wallin wrote: > I have written the announcement of 2.5beta, but it still needs proofreading. > > It would also be good if somebody could add a screenshot of the new cell > editor and cell tool in sheets and maybe also one of the new improved > connectors. I have nice sc

Re: features progress list

2012-06-23 Thread Jaroslaw Staniek
On 23 June 2012 14:20, Jaroslaw Staniek wrote: > On 23 June 2012 14:17, C. Boemann wrote: >> Fine with me >> >> and regarding the shapes, I was going to make exceptions for formula and >> chart. And I'm insisting on Textshape under Words as it's so closely related, >> and for the same reason conn

Re: features progress list

2012-06-23 Thread Jaroslaw Staniek
On 23 June 2012 14:17, C. Boemann wrote: > On Saturday 23 June 2012 14:12:27 Jaroslaw Staniek wrote: >> On 22 June 2012 14:16, C. Boemann wrote: >> > I've updated the css according to my comments and made lists for every >> > application / major shape >> > >> > As far as I'm concerned we are good

Re: features progress list

2012-06-23 Thread C. Boemann
On Saturday 23 June 2012 14:12:27 Jaroslaw Staniek wrote: > On 22 June 2012 14:16, C. Boemann wrote: > > I've updated the css according to my comments and made lists for every > > application / major shape > > > > As far as I'm concerned we are good to go, and I will start populating > > the Word

Re: features progress list

2012-06-23 Thread Jaroslaw Staniek
On 22 June 2012 14:16, C. Boemann wrote: > I've updated the css according to my comments and made lists for every > application / major shape > > As far as I'm concerned we are good to go, and I will start populating the > Words list tonight. I have usability suggestion: move the git parameter (n

Re: Review Request: Fix bug 246898: Take opacity into consideration while drawing venn diagrams

2012-06-23 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105301/ --- (Updated June 23, 2012, 12:05 p.m.) Review request for Calligra. Changes

Re: Review Request: Fix bug 246898: Take opacity into consideration while drawing venn diagrams

2012-06-23 Thread Gopalakrishna Bhat
> On June 20, 2012, 7:16 a.m., Thorsten Zachmann wrote: > > libs/flake/KoGradientBackground.cpp, lines 142-144 > > > > > > Did you check that this does not have any effect on the gradient that > > is saved? I foun

Re: features progress list

2012-06-23 Thread Jaroslaw Staniek
On 21 June 2012 18:23, C. Boemann wrote: > On Wednesday 20 June 2012 12:31:57 Jaroslaw Staniek wrote: >> On 20 June 2012 08:53, C. Boemann wrote: >> > No No. We don't need filtering or anything. Just an update version of >> > what we had. Updated meaning that it handles the extra column for >> >

Announcement written, needs proof reading and screenshot

2012-06-23 Thread Inge Wallin
I have written the announcement of 2.5beta, but it still needs proofreading. It would also be good if somebody could add a screenshot of the new cell editor and cell tool in sheets and maybe also one of the new improved connectors. I have nice screenshots myself, but the hotel internet didn't