Re: Review Request: Fix saving of style child elements

2012-06-10 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105212/ --- (Updated June 11, 2012, 6:49 a.m.) Review request for Calligra. Changes

Review Request: GSoC: Stage: Shape animations docker with no editable information (yet) and shape animations preview

2012-06-10 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105213/ --- Review request for Calligra. Description --- Add a docker to the Anim

Review Request: Fix saving of style child elements

2012-06-10 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105212/ --- Review request for Calligra. Description --- When saving style child

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-10 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103538/ --- (Updated June 10, 2012, 9:42 p.m.) Review request for Calligra. Changes

Re: Review Request: Increase indent on a list item increases the displayed depth of the list i.e 1 becomes 1.1

2012-06-10 Thread C. Boemann
> On June 10, 2012, 6:25 p.m., C. Boemann wrote: > > libs/textlayout/ListItemsHelper.h, line 48 > > > > > > wow it seems we have a lot of duplication here with > > libs/odf/KoOdfNumberDefinition ::formattedNumber

Re: Review Request: Increase indent on a list item increases the displayed depth of the list i.e 1 becomes 1.1

2012-06-10 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105198/#review14586 --- plugins/textshape/TextTool.cpp

Re: Review Request: Increase indent on a list item increases the displayed depth of the list i.e 1 becomes 1.1

2012-06-10 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105198/ --- (Updated June 10, 2012, 6:08 p.m.) Review request for Calligra. Changes

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-10 Thread Paul Mendez
> On June 10, 2012, 4:12 a.m., Thorsten Zachmann wrote: > > I could reproduce the blank slide show again but I don't know yet how to do > > that. Will investigate more. > > > > I found a way that can make Calligra Stage crash. To reproduce: > > o Have a slide show with more then one slide. > >

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105153/#review14584 --- This review has been submitted with commit 940c2833f1ef67f496a

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-10 Thread Thorsten Zachmann
Hello Paul, On Sunday 10 June 2012 15:17:40 C. Boemann wrote: > > Paul Mendez wrote: > > I am going to work in the second bug. Regarding the first I haven't > > found yet how it could happen. The code just set the activePage and > > then call the KPrView method to start the presentatio

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-10 Thread Friedrich W. H. Kossebau
> On June 7, 2012, 2:59 p.m., C. Boemann wrote: > > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp, line 31 > > > > > > Tool tips shouldn't have title case > > Friedrich W. H. Kossebau wrote: >

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-10 Thread C. Boemann
> On June 7, 2012, 2:59 p.m., C. Boemann wrote: > > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp, line 31 > > > > > > Tool tips shouldn't have title case > > Friedrich W. H. Kossebau wrote: >

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-10 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105153/#review14581 --- Ship it! - C. Boemann On June 5, 2012, 4:30 p.m., Friedrich

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-10 Thread Friedrich W. H. Kossebau
> On June 7, 2012, 2:59 p.m., C. Boemann wrote: > > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp, line 31 > > > > > > Tool tips shouldn't have title case > > Friedrich W. H. Kossebau wrote: >

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-10 Thread C. Boemann
> On June 10, 2012, 4:12 a.m., Thorsten Zachmann wrote: > > I could reproduce the blank slide show again but I don't know yet how to do > > that. Will investigate more. > > > > I found a way that can make Calligra Stage crash. To reproduce: > > o Have a slide show with more then one slide. > >

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-10 Thread Paul Mendez
> On June 10, 2012, 4:12 a.m., Thorsten Zachmann wrote: > > I could reproduce the blank slide show again but I don't know yet how to do > > that. Will investigate more. > > > > I found a way that can make Calligra Stage crash. To reproduce: > > o Have a slide show with more then one slide. > >

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-10 Thread Paul Mendez
> On June 10, 2012, 4:34 a.m., Thorsten Zachmann wrote: > > One more thing I noticed. When the zoom level on the slide sorter is quite > > small the buttons do no longer fit into the slide and only the first 2 > > buttons are shown. A fix could be to limit the min zoom level so that > > always

Re: Review Request: Rewrote all list-items using newly defined roles Fixed visibility of 3rd column without using event filter

2012-06-10 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105187/#review14573 --- Ship it! Ship It! - Oleg Kukharchuk On June 9, 2012, 1:18 p