Re: Review Request: Change Stage and Flow to have infinite type canvas

2012-05-13 Thread Thorsten Zachmann
> On May 13, 2012, 7:14 p.m., Inge Wallin wrote: > > libs/widgets/KoZoomController.h, line 124 > > > > > > While 'document' may be what it's called in the zoom controller, I > > think it is confusing. Granted, the

Re: Review Request: Change Stage and Flow to have infinite type canvas

2012-05-13 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104928/#review13799 --- Some observations I made when testing the patch: o When moving

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-13 Thread Thorsten Zachmann
> On May 13, 2012, 7:36 p.m., Inge Wallin wrote: > > I have a feeling that this is a case of the perfect being the enemy of the > > good. I think we should ship this patch and then open new bugs for the > > issues that you found, Zagge. There is no hurry to rush anything in. We have enough ti

Re: Review Request: add image/x-xfig to karbon.desktop and karbonpart.desktop

2012-05-13 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104936/#review13797 --- Ship it! Ship It! - Thorsten Zachmann On May 14, 2012, 1:58

Review Request: add image/x-xfig to karbon.desktop and karbonpart.desktop

2012-05-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104936/ --- Review request for Calligra. Description --- Though the xfig import f

Re: Review Request: Do not show the UI when creating a PDF from a document.

2012-05-13 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104913/#review13789 --- Ship it! Looks good. The only thing I don't understand is the

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-13 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104804/#review13788 --- I have a feeling that this is a case of the perfect being the e

Re: Review Request: Change Stage and Flow to have infinite type canvas

2012-05-13 Thread Inge Wallin
> On May 13, 2012, 7:14 p.m., Inge Wallin wrote: > > libs/widgets/KoZoomController.h, line 124 > > > > > > While 'document' may be what it's called in the zoom controller, I > > think it is confusing. Granted, the

Re: Review Request: Change Stage and Flow to have infinite type canvas

2012-05-13 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104928/#review13786 --- In general I must say that I like this. I have worked with it a

Re: Is KoUnavailPart still useful?

2012-05-13 Thread Friedrich W. H. Kossebau
Am Sonntag, 13. Mai 2012, 17:20:33 schrieb Boudewijn Rempt: > On Sunday 13 May 2012 May, Friedrich W. H. Kossebau wrote: > > Hi, > > > > I am puzzled by KoUnavailPart. Is it still in use? How is an instance of > > the part instantiated? > > > > From the comment in the header kounavail.h (referenc

Re: Is KoUnavailPart still useful?

2012-05-13 Thread Boudewijn Rempt
On Sunday 13 May 2012 May, Friedrich W. H. Kossebau wrote: > Hi, > > I am puzzled by KoUnavailPart. Is it still in use? How is an instance of the > part instantiated? > > From the comment in the header kounavail.h (referencing some KoDocumentChild) > I would guess the part is completely outdate

Is KoUnavailPart still useful?

2012-05-13 Thread Friedrich W. H. Kossebau
Hi, I am puzzled by KoUnavailPart. Is it still in use? How is an instance of the part instantiated? >From the comment in the header kounavail.h (referencing some KoDocumentChild) I would guess the part is completely outdated and just cruft and should be removed. KoUnavailShape has substituted

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

2012-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104873/#review13771 --- This review has been submitted with commit 72ef50ac3bd2bf4325d

Re: Review Request: Do not show the UI when creating a PDF from a document.

2012-05-13 Thread Jos van den Oever
> On May 13, 2012, 10:08 a.m., Boudewijn Rempt wrote: > > Aren't you doing the same thing as in > > https://git.reviewboard.kde.org/r/103476/ here? The patch touches the same code but is not as pervasive. Also this patch does not just concern the printing dialog but also the showing of the mai

Re: Review Request: Do not show the UI when creating a PDF from a document.

2012-05-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104913/#review13769 --- Aren't you doing the same thing as in https://git.reviewboard.k

Re: Review Request: Do not show the UI when creating a PDF from a document.

2012-05-13 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104913/ --- (Updated May 13, 2012, 10:04 a.m.) Review request for Calligra. Changes

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

2012-05-13 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104873/#review13767 --- Ship it! After fixing the two things I pointed out it is good

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

2012-05-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104873/ --- (Updated May 13, 2012, 9:19 a.m.) Review request for Calligra. Changes -

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

2012-05-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104873/ --- (Updated May 13, 2012, 9:13 a.m.) Review request for Calligra. Changes -

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

2012-05-13 Thread Thorsten Zachmann
> On May 13, 2012, 8:52 a.m., Thorsten Zachmann wrote: > > Maybe adding a comment that only the first clip path will be saved for now and a todo for improving it later would be a good idea. - Thorsten --- This is an automatically gener

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

2012-05-13 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104873/#review13764 --- libs/flake/KoPathShape.cpp