Re: Input for ODF plugfest/TC call

2012-04-20 Thread Thorsten Zachmann
On Thursday, April 19, 2012 13:48:52 you wrote: > Hi, > > so here my list of issues that I have had with ODF so far. Please consider > putting them on the table for the plugfest as well as for the TC call :) > > > A) no official test suite > B) spec vs. reality: how to handle files from broken O

Re: Review Request: Increase gap between pages in Words

2012-04-20 Thread Thorsten Zachmann
> On March 3, 2012, 1:11 p.m., Boudewijn Rempt wrote: > > Was this already pushed? Seems like this patch has been committed already and the review request can be close. KWViewModeNormal.cpp:27:#define GAP 20 - Thorsten --- This is an

Re: Review Request: Bug 298134: gcc 4.7 cannot save a ODF file or open a .doc file

2012-04-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104677/#review12729 --- This review has been submitted with commit 11a852fda159100b305

Re: Review Request: Bug 298134: gcc 4.7 cannot save a ODF file or open a .doc file

2012-04-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104677/#review12728 --- This review has been submitted with commit 9f3b7f62947ccda2335

Re: [calligra] /: Make calligra compile with clang

2012-04-20 Thread Stephen Kelly
Boudewijn Rempt wrote: > int n = name.indexOf(' '); > -if (n != -1) { > +if (n > -1) { > kDebug(30518) << "Sheet name converting:" << name; > -name[n] == '_'; > +name.replace(' ','_'); > kDebug(30518) << "Sheet name converted:" << name; > } > -name =

[calligra] /: Make calligra compile with clang

2012-04-20 Thread Boudewijn Rempt
Git commit c804712c97b24a3774a53a3825f50762089f1f49 by Boudewijn Rempt. Committed on 20/04/2012 at 16:35. Pushed by rempt into branch 'master'. Make calligra compile with clang Clang has some additional restriction. if (foo = bar) becomes if ((foo = bar)), while (foo=bar) while ((foo=bar)) and i

Patch set for Calligra

2012-04-20 Thread Matthew Rezny
I have compiled Calligra on FreeBSD with Clang, which is now part of the base system as alternative to gcc. In doing so, I have put together a set of patches to quiet some warning and quell some errors as Clang's parser is more strict than gcc. Some of the warnings led me to correct subtle erro

Re: Review Request: Bug 298134: gcc 4.7 cannot save a ODF file or open a .doc file

2012-04-20 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104677/#review12723 --- Ship it! Also to 2.4, please! - Boudewijn Rempt On April 19

Re: Input for ODF plugfest/TC call

2012-04-20 Thread Boudewijn Rempt
On Fri, 20 Apr 2012, Matus Uzak wrote: Hello, a comment from filters point of view: > In regards to the test sets: I would really prefer to have a test set that > easily calculates a score for each product. That is however quite some work. > We have some tests in calligra, that would be better

Re: Input for ODF plugfest/TC call

2012-04-20 Thread Matus Uzak
Hello, a comment from filters point of view: > In regards to the test sets: I would really prefer to have a test set that > easily calculates a score for each product. That is however quite some work. > We have some tests in calligra, that would be better to have outside Calligra. http://websvn.

Re: Input for ODF plugfest/TC call

2012-04-20 Thread Jos van den Oever
On Thursday 19 April 2012 13:48:52 PM Friedrich W. H. Kossebau wrote: > so here my list of issues that I have had with ODF so far. Please consider > putting them on the table for the plugfest as well as for the TC call :) I have brought up some points in the discussion. > A) no official test suit

Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

2012-04-20 Thread Boudewijn Rempt
I'm in the middle of a rather tricky refactoring, so it'll be a day before I can play with branches again. Same goes for Gopal's review request, actually. Boudewijn On Fri, 20 Apr 2012, Friedrich W. H. Kossebau wrote: This is an automatically generated e-mail. To reply, visit: http://git.re

Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

2012-04-20 Thread Friedrich W. H. Kossebau
> On April 19, 2012, 6:23 a.m., Boudewijn Rempt wrote: > > It looks good to me. Krita doesn't need a tab chooser. (Well, technically, > > it could be useful if the active shape on a vector layer is a text shape, > > but I'm not sure that's something our users really care about.) For consistenc

Re: Review Request: remove unmaintained plugins from Calligra

2012-04-20 Thread Mani N C
I did not use the plugin recently, thought it was working fine. I will check what is the problem in the plugin. Though I am not active in taking part in conversations, I read most of the mails from the mailing list. Please redirect me if you get any issues regarding it. Thanks, On Fri, Apr 20, 2