Re: Using the Tables brand/trade name for a spreadsheet application

2012-03-12 Thread Marijn Kruisselbrink
Hi Daniel, We did of course use google to try to make sure that we wouldn't use any name that might conflict with existing software, and unfortunately didn't come across your application (also our application is called "Calligra Tables", not "Tables"). But since we of course don't want to couse

Re: Review Request: Fix displaying international characters in calculated values

2012-03-12 Thread Dimitrios Tanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104246/#review11344 --- Ship it! Ship It! - Dimitrios Tanis On March 12, 2012, 10:4

Review Request: Fix displaying international characters in calculated values

2012-03-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104246/ --- Review request for Calligra, Adam Pigg and Dimitrios Tanis. Description --

Re: RC2

2012-03-12 Thread Cyrille Berger Skott
On Monday 12 Mar 2012, Boudewijn Rempt wrote: > On Monday 12 March 2012 Mar, Marijn Kruisselbrink wrote: > > I have a patch ready here locally to rename Calligra Tables to Calligra > > Sheets, I'm just not sure anymore what I should do with it... > > As far as I'm concerned, push it master and to

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 5:42 p.m.) Review request for Calligra. Changes

[SOLVED] Re: How to... get foreground and background color in a shape?

2012-03-12 Thread Friedrich W. H. Kossebau
Am Montag, 12. März 2012, 17:17:29 schrieb Thorsten Zachmann: > On Monday, March 12, 2012 16:20:03 Friedrich W. H. Kossebau wrote: > > Hi, > > > > hopefully soon a new version of the prison library is released, which will > > enable me to easily control the foreground and background colors of the

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 4:34 p.m.) Review request for Calligra. Descrip

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 4:34 p.m.) Review request for Calligra. Changes

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
> On March 12, 2012, 4:27 a.m., Thorsten Zachmann wrote: > > plugins/barcodeshape/barcodeshape.cpp, lines 206-210 > > > > > > I think this should be written better inside a switch statement. Is the > > static_cast

Re: How to... set additional magnetic points/lines to a shape?

2012-03-12 Thread Thorsten Zachmann
On Monday, March 12, 2012 16:20:28 Friedrich W. H. Kossebau wrote: > Hi, > > one thing you might have noticed in the barcode shape is that there is a > margin around the actual content for at least the QR and DataMatrix types. > This is because for these some kind of 'quiet zone' is defined, so th

Re: How to... get foreground and background color in a shape?

2012-03-12 Thread Thorsten Zachmann
On Monday, March 12, 2012 16:20:03 Friedrich W. H. Kossebau wrote: > Hi, > > hopefully soon a new version of the prison library is released, which will > enable me to easily control the foreground and background colors of the > barcode image, without doing my own QImage manipulation hacks which I

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
Hi Adam, Am Montag, 12. März 2012, 08:40:13 schrieb Adam Pigg: > Kexi could do with an implementation of barcodes based on this, becuase the > current version is hand-built, not using any library, and while it is > assumed to work, its certainly not backed up with anything fully tested. Ah, had n

How to... set additional magnetic points/lines to a shape?

2012-03-12 Thread Friedrich W. H. Kossebau
Hi, one thing you might have noticed in the barcode shape is that there is a margin around the actual content for at least the QR and DataMatrix types. This is because for these some kind of 'quiet zone' is defined, so the pattern can be more easily detected. Just, if one layouts some document/

How to... get foreground and background color in a shape?

2012-03-12 Thread Friedrich W. H. Kossebau
Hi, hopefully soon a new version of the prison library is released, which will enable me to easily control the foreground and background colors of the barcode image, without doing my own QImage manipulation hacks which I avoided so far, so it's just black on white for now. But after an initial

Re: Review Request: Make parameter for KoShapeSavingContext::imageHref(...) const

2012-03-12 Thread Thorsten Zachmann
Hello Friedrich, On Monday, March 12, 2012 14:48:29 Friedrich W. H. Kossebau wrote: > > On March 12, 2012, 4:18 a.m., Commit Hook wrote: > > > This review has been submitted with commit > > > cc1069d8d8f6f782acb50d596528b5beab425793 by Friedrich W. H. Kossebau > > > to branch master. > > Okay to

Re: Review Request: Fix crash in Picture shape if no picture is set yet

2012-03-12 Thread Thorsten Zachmann
Hello Friedrich, On Monday, March 12, 2012 14:51:41 Friedrich W. H. Kossebau wrote: > > On March 12, 2012, 6:29 a.m., Commit Hook wrote: > > > This review has been submitted with commit > > > 83213ec798c49d06246cf43765f89a1f3a214a15 by Friedrich W. H. Kossebau > > > to branch master. > > Okay to

Re: Review Request: Fix crash in Picture shape if no picture is set yet

2012-03-12 Thread Friedrich W. H. Kossebau
> On March 12, 2012, 6:29 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 83213ec798c49d06246cf43765f89a1f3a214a15 by Friedrich W. H. Kossebau to > > branch master. Okay to backport to 2.4? Or needs a separate review? - Friedrich W. H. --

Re: Review Request: Make parameter for KoShapeSavingContext::imageHref(...) const

2012-03-12 Thread Friedrich W. H. Kossebau
> On March 12, 2012, 4:18 a.m., Commit Hook wrote: > > This review has been submitted with commit > > cc1069d8d8f6f782acb50d596528b5beab425793 by Friedrich W. H. Kossebau to > > branch master. Okay to backport also to 2.4? And how is ABI versioning handled, BTW, as this is BIC? - Friedrich

Re: [calligra] filters: libmsooxml: parse and use line styles from the DrawingML theme properly

2012-03-12 Thread Matus Uzak
.. thanks Thorsten, I did not make it to my laptop during the weekend. On Sun, Mar 11, 2012 at 10:49 AM, Thorsten Zachmann wrote: > Hello Uzak, > > > > > > > I have tested all commits of Uzak from this week. The id's are : > > > > > > e495a3001306eab7a26ea1f6726774ef421419db > > > 6a15752fe922dab

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Adam Pigg
Kexi could do with an implementation of barcodes based on this, becuase the current version is hand-built, not using any library, and while it is assumed to work, its certainly not backed up with anything fully tested. On Mon, Mar 12, 2012 at 5:03 AM, Thorsten Zachmann wrote: >This is an aut

Re: RC2

2012-03-12 Thread Boudewijn Rempt
On Monday 12 March 2012 Mar, Marijn Kruisselbrink wrote: > I have a patch ready here locally to rename Calligra Tables to Calligra > Sheets, I'm just not sure anymore what I should do with it... As far as I'm concerned, push it master and to 2.4. Answer the x-tables guy and then we need to fix u