Re: release issue

2012-03-09 Thread Thorsten Zachmann
Hello, > There is a bug in qt4.8 that makes textediting crash. And it's not really > practical to workaround it in Calligra. Is it an assert or is it a real crash? > More specifically qt4.8 crashes whenever you eg cursor->setPosition or > editing that moves the cursor position. > > Unless you w

Re: release issue

2012-03-09 Thread C. Boemann
On Friday 09 March 2012 23:25:10 Jaroslaw Staniek wrote: > On 9 March 2012 16:48, C. Boemann wrote: > > Hi > > > > There is a bug in qt4.8 that makes textediting crash. And it's not really > > practical to workaround it in Calligra. > > > > More specifically qt4.8 crashes whenever you eg cursor-

Re: release issue

2012-03-09 Thread Jaroslaw Staniek
On 9 March 2012 16:48, C. Boemann wrote: > Hi > > There is a bug in qt4.8 that makes textediting crash. And it's not really > practical to workaround it in Calligra. > > More specifically qt4.8 crashes whenever you eg cursor->setPosition or editing > that moves the cursor position. > > Unless you

Re: release issue

2012-03-09 Thread Sven Langkamp
On Fri, Mar 9, 2012 at 4:48 PM, C. Boemann wrote: > Hi > > There is a bug in qt4.8 that makes textediting crash. And it's not really > practical to workaround it in Calligra. > > More specifically qt4.8 crashes whenever you eg cursor->setPosition or > editing > that moves the cursor position. > >

Re: Review Request: Bug 290656( Meaningless action text in cell context menu) resolved

2012-03-09 Thread Jigar Raisinghani
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104174/ --- (Updated March 9, 2012, 8:41 p.m.) Review request for Calligra. Changes

Re: Review Request: Bug 290656( Meaningless action text in cell context menu) resolved

2012-03-09 Thread Jigar Raisinghani
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104174/ --- (Updated March 9, 2012, 8:38 p.m.) Review request for Calligra. Changes

Re: Review Request: Bug 290656( Meaningless action text in cell context menu) resolved

2012-03-09 Thread Marijn Kruisselbrink
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104174/#review11265 --- Ship it! Other than the one comment below, it looks good to me

Fwd: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor

2012-03-09 Thread C. Boemann
Could someone please review and take it for a spin so i can backport it -- Forwarded Message -- Subject: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor Date: Friday 09 March 2012 From: "C. Boemann" To: kde-comm...@kde.org Git commit

release issue

2012-03-09 Thread C. Boemann
Hi There is a bug in qt4.8 that makes textediting crash. And it's not really practical to workaround it in Calligra. More specifically qt4.8 crashes whenever you eg cursor->setPosition or editing that moves the cursor position. Unless you wrap those call inside begin/endEditBlock pairs. I've d

Re: [calligra] filters: libmsooxml: parse and use line styles from the DrawingML theme properly

2012-03-09 Thread Boudewijn Rempt
On Fri, 9 Mar 2012, Matus Uzak wrote: Hi, yes, my this week's commits should be backported to 2.4, because previously missing content gets displayed.  Do I have to make review requests or are we fine with those? You're the guru on this subject... I'd say we should be fine with backporting

Re: [calligra] filters: libmsooxml: parse and use line styles from the DrawingML theme properly

2012-03-09 Thread Matus Uzak
Hi, yes, my this week's commits should be backported to 2.4, because previously missing content gets displayed. Do I have to make review requests or are we fine with those? On Fri, Mar 9, 2012 at 2:02 PM, Boudewijn Rempt wrote: > On Thursday 08 March 2012 Mar, Matus Uzak wrote: > > Git commit

Re: [calligra] filters: libmsooxml: parse and use line styles from the DrawingML theme properly

2012-03-09 Thread Boudewijn Rempt
On Thursday 08 March 2012 Mar, Matus Uzak wrote: > Git commit 6d04bb240228b4b5f650dd7411eb410fc345fbf5 by Matus Uzak. > Committed on 08/03/2012 at 16:23. > Pushed by uzak into branch 'master'. > > libmsooxml: parse and use line styles from the DrawingML theme properly Nice! Should these fixes be