Re: Review Request: This patch supports the navigation of the text doc in CA according to user's wish

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104092/#review10975 --- This review has been submitted with commit 2ad4d60de4d805d6ed8

Re: Review Request: This patch supports the navigation of the text doc in CA according to user's wish

2012-02-27 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104092/ --- (Updated Feb. 28, 2012, 3:10 a.m.) Review request for Calligra and Shantan

Re: Review Request: This patch supports the navigation of the text doc in CA according to user's wish

2012-02-27 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104092/#review10957 --- active/qml/TextDocumentLeftToolbar.qml

Re: Review Request: Maintain text selection through undo/redo

2012-02-27 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104098/#review10955 --- on closer thought i don't think we can ever get this right. The

Review Request: Maintain text selection through undo/redo

2012-02-27 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104098/ --- Review request for Calligra, Pierre Stirnweiss and C. Boemann. Description

Re: Review Request: This patch supports the navigation of the text doc in CA according to user's wish

2012-02-27 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104092/#review10953 --- Two minor issues as listed below, looks good otherwise. About t

Review Request: This patch supports the navigation of the text doc in CA according to user's wish

2012-02-27 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104092/ --- Review request for Calligra and Shantanu Tushar Jha. Description ---

Re: KDE/kdesdk/kapptemplate/templates/C++/flake

2012-02-27 Thread Boudewijn Rempt
KoTool.h has become KoToolBase.h in January 2010... On Mon, 27 Feb 2012, David Faure wrote: SVN commit 1282459 by dfaure: Port to K_EXPORT_PLUGIN/K_PLUGIN_FACTORY, but this stuff uses KoTool.h which doesn't seem to exist anymore. CCMAIL: calligra-devel@kde.org M +4 -4 %{APPNAME}Plugin

KDE/kdesdk/kapptemplate/templates/C++/flake

2012-02-27 Thread David Faure
SVN commit 1282459 by dfaure: Port to K_EXPORT_PLUGIN/K_PLUGIN_FACTORY, but this stuff uses KoTool.h which doesn't seem to exist anymore. CCMAIL: calligra-devel@kde.org M +4 -4 %{APPNAME}Plugin.cpp M +2 -2 %{APPNAME}Plugin.h --- trunk/KDE/kdesdk/kapptemplate/templates/C++/fl

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-27 Thread Boudewijn Rempt
> On Feb. 26, 2012, 4:16 a.m., Thorsten Zachmann wrote: > > libs/flake/KoShape.cpp, lines 1576-1577 > > > > > > According to ODF 19.187.2 does not support xml:id. > > Please revert this change. It does not refere

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-27 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/ --- (Updated Feb. 27, 2012, 8:37 a.m.) Review request for Calligra. Changes