Re: Review Request: GUI to edit pictureshapes

2012-01-02 Thread Silvio Heinrich
> On Jan. 2, 2012, 9:03 p.m., Jarosław Staniek wrote: > > plugins/pictureshape/PictureShape.h, line 42 > > > > > > Is this how we agreed to mark private namespaces? I don't understand. What do you mean? - Silvio

Re: Review Request: GUI to edit pictureshapes

2012-01-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103402/#review9480 --- plugins/pictureshape/PictureShape.h

Re: Review Request: Replace KSpread with Tables in drop down box of Configure Toolbars dialog

2012-01-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103615/#review9479 --- Should be or ? If this visible in Tables app only, maybe coul

Review Request: Replace KSpread with Tables in drop down box of Configure Toolbars dialog

2012-01-02 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103615/ --- Review request for Calligra and Marijn Kruisselbrink. Description ---

Review Request: tables documentation update for 2.4

2012-01-02 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103614/ --- Review request for Calligra, Marijn Kruisselbrink and Yuri Chornoivan. Des

Re: Review Request: Paste an image from the clipboard to words

2012-01-02 Thread Silvio Heinrich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103484/ --- (Updated Jan. 2, 2012, 4:52 p.m.) Review request for Calligra. Changes -

Re: Review Request: GUI to edit pictureshapes

2012-01-02 Thread Silvio Heinrich
> On Dec. 21, 2011, 8:20 a.m., Thorsten Zachmann wrote: > > plugins/pictureshape/ClippingRect.cpp, lines 49-52 > > > > > > there should be only 1 space between the end of the variable and the *. > > Please change th

Re: Review Request: GUI to edit pictureshapes

2012-01-02 Thread Silvio Heinrich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103402/ --- (Updated Jan. 2, 2012, 4:08 p.m.) Review request for Calligra. Changes -

Re: Review Request: Don't strip spaces when reading xml

2012-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103568/#review9450 --- This review has been submitted with commit 16bc36adc6a6ead69e21

Re: Review Request: Explicitly accept mouse event on canvas level to prevent move window around

2012-01-02 Thread Boudewijn Rempt
> On Dec. 13, 2011, 3:01 p.m., Boudewijn Rempt wrote: > > Ship It! Is this already pushed? - Boudewijn --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103392/#review8922 -

Re: Review Request: Fix clone layers updating

2012-01-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103021/#review9425 --- Dmitry says the bug is fixed in trunk -- can we close the reques

Re: Review Request: Remove some deprecated calls and fix a typing error

2012-01-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103057/#review9422 --- Ship it! Looks good to me -- has it already been pushed? - Bou

Re: Review Request: Fixes 274118 and couple of other fixes

2012-01-02 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101500/#review9421 --- it has been commited - C. Boemann On June 11, 2011, 8:17 p.m.

Re: Review Request: Fixes 274118 and couple of other fixes

2012-01-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101500/#review9420 --- Any news on this patch? Is it still relevant? - Boudewijn Rempt

Re: Review Request: Don't strip spaces when reading xml

2012-01-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103568/#review9419 --- Ship it! - Boudewijn Rempt On Dec. 29, 2011, 1:26 p.m., Thors