Re: packaging feedback

2011-12-01 Thread Rex Dieter
Cyrille Berger Skott wrote: > That said, it is a private > library, but I don't think cmake has a way to prevent installation of .so > symlinks. Turns out there is, using cmake's NAMELINK_SKIP magic: install(TARGETS foo ${INSTALL_TARGETS_DEFAULT_ARGS} LIBRARY NAMELINK_SKIP) -- rex

Re: Review Request: User defined variables (2)

2011-12-01 Thread Sebastian Sauer
> On Nov. 28, 2011, 6:53 a.m., Thorsten Zachmann wrote: > > plugins/variables/UserVariable.h, lines 65-67 > > > > > > Is it possible to move the option widget into its own class. That makes > > it easier for applica

Re: packaging feedback

2011-12-01 Thread Cyrille Berger Skott
Hi, On Thursday 01 December 2011, Adrien wrote: > – When quitting a calligra application, I got a message « impossible for > KDEinit to launch calligrawords ». It happen every time on the closing of > the app. Probably fixed by Yue Liu in 4169833df0d144092b07f199858fe53311e360f6 . > – I forgot to

Re: Review Request: User defined variables (2)

2011-12-01 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103276/ --- (Updated Dec. 1, 2011, 7:13 p.m.) Review request for Calligra and Thorsten

Re: Review Request: User defined variables (2)

2011-12-01 Thread Sebastian Sauer
> On Nov. 28, 2011, 6:53 a.m., Thorsten Zachmann wrote: > > libs/kotext/KoVariableManager.cpp, line 137 > > > > > > This should not use namedItemNS as this will iterate over all elements > > which can be very long

packaging feedback

2011-12-01 Thread Adrien
Hi, When packaging calligra beta 4, I got some issues : – It seems to have a unnecessary dependency for calligratables : dpkg-shlibdeps: warning: dependency on libgslcblas.so.0 could be avoided if "debian/calligratables/usr/lib/kde4/kspreadsolver.so" were not uselessly linked against it (they u

Re: Review Request: Add markers (arrows and other stuff put at the end of a line)

2011-12-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103152/#review8643 --- This review has been submitted with commit b99fe3f9eb92e9356b4e