Re: Patch: Remove some deprecated functions

2011-11-06 Thread Jaroslaw Staniek
On 6 November 2011 17:56, Mauro wrote: >> The function >> >> formatDate(date, KLocale::MonthName, KLocale::ShortName) >> >> was introduced in 4.6 so you need to ifdef that as we still support compiling >> against kde 4.4. > > I apologize, I didn't know you still need to support KDE 4.4 Hi, It ma

Review Request: Remove some deprecated calls and fix a typing error

2011-11-06 Thread Mauro Levra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103057/ --- Review request for Calligra. Description --- Remove some deprecated c

Re: Patch: Remove some deprecated functions

2011-11-06 Thread Mauro
Hello Thorsten, On Sunday, November 06, 2011 05:13 Thorsten Zachmann wrote: > What part of Calligra does interest you the most? As a developer I have no preferences, since I know near nothing of Calligra code; so if there is one part that is in more need, or that is easier to start with, I will b

Re: Review Request: Style inheritance

2011-11-06 Thread Jarosław Staniek
> On Nov. 6, 2011, 2:01 p.m., Jarosław Staniek wrote: > > libs/kotext/styles/KoTableCellStyle.h, line 159 > > > > > > cannot be const? > > C. Boemann wrote: > well it's returning an internal member and yes that

Re: Review Request: Style inheritance

2011-11-06 Thread C. Boemann
> On Nov. 6, 2011, 2:01 p.m., Jarosław Staniek wrote: > > libs/kotext/styles/KoParagraphStyle.h, line 677 > > > > > > Extra bool arg is not good API, one day we'll remove all. Would be nice > > to avoid adding new

Re: Review Request: Style inheritance

2011-11-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/#review7974 --- libs/kotext/styles/KoCharacterStyle.cpp

Re: Review Request: Style inheritance

2011-11-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- (Updated Nov. 6, 2011, 8:50 a.m.) Review request for Calligra. Changes -

Re: Review Request: Style inheritance

2011-11-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- (Updated Nov. 6, 2011, 9:47 a.m.) Review request for Calligra. Changes -