Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7420 --- Ship it! I agree with Dmitry -- looks good to me. Can you push

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Torio Mlshi
> On Oct. 16, 2011, 6:04 p.m., Dmitry Kazakov wrote: > > Hi! > > > > It's a really cool idea to use uuids here! I think the patch is very good, > > but i have one small concern. Is it possible to remove old code like > > copyFromName(), setCopyFromName() and findNodeByName()? Probably, map the

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7400 --- Hi! It's a really cool idea to use uuids here! I think the patc

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7401 --- Hi! It's a really cool idea to use uuids here! I think the patc

Re: Review Request: User defined variables

2011-10-16 Thread Thorsten Zachmann
> On Oct. 16, 2011, 4:56 p.m., Thorsten Zachmann wrote: > > Looking at the patch it does not support loading of the user defined > > variables for kopageapp. Also I think support for tables should be added. > > > > I think loading/saving should be done as the saving is done in kopageapp as > >

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/ --- (Updated Oct. 16, 2011, 4:59 p.m.) Review request for Calligra and Boudewi

Re: Review Request: User defined variables

2011-10-16 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7393 --- Looking at the patch it does not support loading of the user def

Re: Review Request: User defined variables

2011-10-16 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7392 --- Looking at the patch it does not support loading of the user def

Re: Review Request: User defined variables

2011-10-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7389 --- Ship it! As far as I am concerned you can commit whenever you f

Re: Review Request: User defined variables

2011-10-16 Thread Sebastian Sauer
> On Oct. 16, 2011, 3:23 p.m., C. Boemann wrote: > > libs/kotext/KoVariableManager.h, line 59 > > > > > > woudn't enums be better then? Maybe. I made it a string so we don't lose unknown types but later changed the

Re: Review Request: User defined variables

2011-10-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/#review7386 --- Looks very nice all in all. I see no objections to allowing it i

Re: composite_copy

2011-10-16 Thread Boudewijn Rempt
On Sunday 16 October 2011 Oct, Boudewijn Rempt wrote: > Erm... Where did the ordinary composite_copy composite op go? Did we disable > it intentionally? We need something that just copies the dst disregarding src > to make things like filter layers with color to alpha work. > Disregard... Wrong

composite_copy

2011-10-16 Thread Boudewijn Rempt
Erm... Where did the ordinary composite_copy composite op go? Did we disable it intentionally? We need something that just copies the dst disregarding src to make things like filter layers with color to alpha work. -- Boudewijn Rempt http://www.valdyas.org, http://www.krita.org, http://www.boude

Re: Review Request: User defined variables

2011-10-16 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/ --- (Updated Oct. 16, 2011, 9:47 a.m.) Review request for Calligra. Descript

Re: Review Request: User defined variables

2011-10-16 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/ --- (Updated Oct. 16, 2011, 9:42 a.m.) Review request for Calligra. Descript

Fwd: tasks for Google Code-in

2011-10-16 Thread Cyrille Berger Skott
-- Forwarded Message -- Subject: tasks for Google Code-in Date: Saturday 15 October 2011, 15:19:48 From: Lydia Pintscher To: ... Heya folks :) Google Code-in (http://www.google- melange.com/gci/document/show/gci_program/google/gci2011/about) has been announced again for this y

Review Request: User defined variables

2011-10-16 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102890/ --- Review request for Calligra. Description --- Following patch implemen

Re: Review Request: New UI for words, some hopefully insignificat changes to other apps

2011-10-16 Thread Cyrille Berger Skott
> On Oct. 16, 2011, 6:08 a.m., Thorsten Zachmann wrote: > > My biggest concern is about constiency between the different applications > > changes with this patch. Would it not be better if that would be a common > > option the user can select so all applications would behave like that? Basical