Re: Calligra on Tizen and beyond

On Thursday, October 13, 2011 18:24:39 PM Cyrille Berger Skott wrote: > On Thursday 13 October 2011, Jos van den Oever wrote: > > Since it's based on webkit, the source code should be available too, i > > did not see the link to that though. > > Seems to be here: > http://sourceforge.net/adobe/ado

Re: Calligra on Tizen and beyond

On Thursday 13 October 2011, Jos van den Oever wrote: > Since it's based on webkit, the source code should be available too, i did > not see the link to that though. Seems to be here: http://sourceforge.net/adobe/adobe-webkit/home/WebKit and Adobe Contributions/ -- Cyrille Berger Skott _

Re: Review Request: Add PDF support to KOConverter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102837/ --- (Updated Oct. 13, 2011, 11:01 a.m.) Review request for Calligra. Changes

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 7:33 p.m., Jan Hambrecht wrote: > > tools/converter/koconverter.cpp, lines 71-73 > > > > > > I think you should check for a null pointer before defererencing. Done and done - i actually did befor

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 5:22 p.m., Sebastian Sauer wrote: > > tools/converter/koconverter.cpp, line 76 > > > > > > maybe don't silent fail and return KoFilter::OK in that case? So, > > something like > > > > st

Re: Review Request: Add PDF support to KOConverter

> On Oct. 12, 2011, 3:05 p.m., Jarosław Staniek wrote: > > tools/converter/koconverter.cpp, line 48 > > > > > > const for bool not needed (I know this was already there but this is > > opportunity to fix ;) Quite t