Re: Review Request: Pass KoCanvasBase in shape paint methods (just like for paintDecoration)

2011-10-09 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102809/ --- (Updated Oct. 9, 2011, 5:10 p.m.) Review request for Calligra. Changes -

Re: Review Request: Pass KoCanvasBase in shape paint methods (just like for paintDecoration)

2011-10-09 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102809/ --- (Updated Oct. 9, 2011, 4:07 p.m.) Review request for Calligra. Changes -

Re: About Calligra Active and what it should intend to be

2011-10-09 Thread Boudewijn Rempt
On Sunday 09 October 2011 Oct, Friedrich W. H. Kossebau wrote: <...> Well, there's already, for instance, an Okular generator plugin in Calligra that uses the Calligra engine to create pages of a presentation in ppt, pptx or odp for Okular. But Okular and Calligra are different in many ways, an

Re: About Calligra Active and what it should intend to be

2011-10-09 Thread Friedrich W. H. Kossebau
Hi, may I give a comment as outsider on the issue (also cross-posting okular- devel, please follow-ups only to calligra-devel@kde.org) Mardi, le 4 octobre 2011, à 08:58, Inge Wallin a écrit: > On Monday, October 03, 2011 16:24:21 Vít Pelčák wrote: > > 2011/10/3 Shantanu Tushar Jha : > > > Hi, > >

Re: Review Request: Pass KoCanvasBase in shape paint methods (just like for paintDecoration)

2011-10-09 Thread Boudewijn Rempt
> On Oct. 9, 2011, 2:58 a.m., Thorsten Zachmann wrote: > > I think we should pass a PaintingContext to the paint method instead of > > adding new parameters. That has the benefit of making it future prove. > > There are some things I would like to pass to painting for e.g. animations > > in st

Re: Review Request: Pass KoCanvasBase in shape paint methods (just like for paintDecoration)

2011-10-09 Thread C. Boemann
> On Oct. 9, 2011, 2:58 a.m., Thorsten Zachmann wrote: > > I think we should pass a PaintingContext to the paint method instead of > > adding new parameters. That has the benefit of making it future prove. > > There are some things I would like to pass to painting for e.g. animations > > in st

Re: Review Request: Pass KoCanvasBase in shape paint methods (just like for paintDecoration)

2011-10-09 Thread Boudewijn Rempt
> On Oct. 9, 2011, 2:58 a.m., Thorsten Zachmann wrote: > > I think we should pass a PaintingContext to the paint method instead of > > adding new parameters. That has the benefit of making it future prove. > > There are some things I would like to pass to painting for e.g. animations > > in st

Re: Review Request: Removing lbgsf dependency

2011-10-09 Thread Stuart Dickson
> On Oct. 6, 2011, 3:03 p.m., Matus Uzak wrote: > > filters/words/msword-odf/wv2/src/headers.cpp, line 115 > > > > > > Why a QList instead of an array here, you know the number of items. plcfsed.count() is not a co