Re: Calligra akademy mentoring program - call for participation

2011-09-19 Thread Boudewijn Rempt
On Tuesday 20 September 2011 Sep, Jaroslaw Staniek wrote: > On 20 September 2011 08:26, Boudewijn Rempt wrote: > > Note that the url is now > > http://community.kde.org/Calligra/Calligra_academy -- like I originally > > proposed. "akademy" with a 'k' is a bit confusing with the yearly kde

Re: Calligra akademy mentoring program - call for participation

2011-09-19 Thread Jaroslaw Staniek
On 20 September 2011 08:26, Boudewijn Rempt wrote: > Note that the url is now         > http://community.kde.org/Calligra/Calligra_academy -- like I originally > proposed. "akademy" with a 'k' is a bit confusing with the yearly kde > meet-up. I hadn't noticed, but Lydia was confused by it. > Mi

Re: Calligra akademy mentoring program - call for participation

2011-09-19 Thread Boudewijn Rempt
Note that the url is now http://community.kde.org/Calligra/Calligra_academy -- like I originally proposed. "akademy" with a 'k' is a bit confusing with the yearly kde meet-up. I hadn't noticed, but Lydia was confused by it. -- Boudewijn Rempt http://www.valdyas.org, http://www.krita.org

Re: Review Request: Add icons to document structure docker context menu

2011-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102627/#review6652 --- This review has been submitted with commit 3bf36cf887a49c5ca18d

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- (Updated Sept. 19, 2011, 11:27 p.m.) Review request for Calligra. Change

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread C. Boemann
> On Sept. 19, 2011, 8:34 p.m., Jan Hambrecht wrote: > > Is there any reason why you are not using > > KoShape::setApplicationData/KoShape::applicationData? > > C. Boemann wrote: > yes it already used for kotextshapedata in text shapes > > Jan Hambrecht wrote: > I only found places whe

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread C. Boemann
> On Sept. 19, 2011, 8:34 p.m., Jan Hambrecht wrote: > > Is there any reason why you are not using > > KoShape::setApplicationData/KoShape::applicationData? > > C. Boemann wrote: > yes it already used for kotextshapedata in text shapes > > Jan Hambrecht wrote: > I only found places whe

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread Jan Hambrecht
> On Sept. 19, 2011, 8:34 p.m., Jan Hambrecht wrote: > > Is there any reason why you are not using > > KoShape::setApplicationData/KoShape::applicationData? > > C. Boemann wrote: > yes it already used for kotextshapedata in text shapes I only found places where a frame is set to a shape as

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread C. Boemann
> On Sept. 19, 2011, 8:34 p.m., Jan Hambrecht wrote: > > Is there any reason why you are not using > > KoShape::setApplicationData/KoShape::applicationData? yes it already used for kotextshapedata in text shapes - C. --- This is an aut

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6641 --- Is there any reason why you are not using KoShape::setApplicati

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- (Updated Sept. 19, 2011, 3:52 p.m.) Review request for Calligra. Changes

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6638 --- The review request misses KoAncher.{h,cpp}. - Thorsten On Sep

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- (Updated Sept. 19, 2011, 2:54 p.m.) Review request for Calligra. Changes

Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-19 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- Review request for Calligra. Summary --- Stores a new class KoAnchor

Re: Calligra akademy mentoring program - call for participation

2011-09-19 Thread Inge Wallin
On Saturday, September 17, 2011 12:56:45 Hanna Skott wrote: > Hey all Calligra developers, > > After some discussions on how to take care of new people who want to > become contributors, this is the suggestion that was written up: > http://community.kde.org/Calligra/Calligra_akademy > > We are no

Coding style reminder

2011-09-19 Thread Boudewijn Rempt
Hi everyone, Just a gentle reminder of the coding style we use in Calligra: * no tabs, an indent is four spaces * always use braces around an if block, even if it's just one line if (bla) { doSomething(); } * for and if braces on the line of the condition if (bla) {} * function braces

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6633 --- This review has been submitted with commit f093e1f83df4536f226f