Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-17 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/ --- (Updated Aug. 18, 2011, 12:04 a.m.) Review request for Calligra. Changes

Re: [calligra] tools/cstester/visualimagecompare: Remove usage of PRETTY_FUNCTION

2011-08-17 Thread Cyrille Berger Skott
Hi, I get a compilation error: http://my.cdash.org/viewBuildError.php?buildid=221594 On Wednesday 17 August 2011, Boudewijn Rempt wrote: > Git commit d61d0a1a5d09e46edc581f31e067a155410c8942 by Boudewijn Rempt. > Committed on 17/08/2011 at 21:38. > Pushed by rempt into branch 'master'. > > Remo

Re: Review Request: Fix crash in stage's slide sorter when one page is bigger than the viewport

2011-08-17 Thread Peter Simonsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102351/ --- (Updated Aug. 17, 2011, 7:25 p.m.) Review request for Calligra. Changes

Re: Review Request: Fix crash in stage's slide sorter when one page is bigger than the viewport

2011-08-17 Thread Peter Simonsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102351/ --- (Updated Aug. 17, 2011, 2:58 p.m.) Review request for Calligra. Summary

Review Request: Fix crash in slide sorter when one page is bigger than the viewport

2011-08-17 Thread Peter Simonsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102351/ --- Review request for Calligra. Summary --- The slides sorter crashed on

Re: [calligra] filters: Fix bug 276268 - “Format not recongnized” Error is displaying while opening the attached Excel 2010 file

2011-08-17 Thread Marijn Kruisselbrink
And for documentation sake: The real problem is that the whole relying on QUALIFIED_NAME (and certain hardcoded namespace prefixes) is completely broken by design. There are no elements without namespaces anywhere here, just elements with empty namespace prefixes, but because of the (broken) des

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-17 Thread Jan Hambrecht
> On Aug. 16, 2011, 5:45 p.m., Jan Hambrecht wrote: > > Instead of passing a new bool parameter to all these methods of > > KoXmlReader, I would prefer having a single function > > setWhitespaceStrippingEnabled. This sets an internal flag which can be used > > at all the places necessary. > >

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-17 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review5767 --- libs/odf/KoXmlReader.cpp

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-17 Thread Jaime Torres Amate
> On Aug. 16, 2011, 5:45 p.m., Jan Hambrecht wrote: > > Instead of passing a new bool parameter to all these methods of > > KoXmlReader, I would prefer having a single function > > setWhitespaceStrippingEnabled. This sets an internal flag which can be used > > at all the places necessary. The