Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101873/#review4668 --- I tested the patch. Unfortunately the chosen implementation to p

Review Request: Take tool actions from the actioncollection instead of disable them

2011-07-12 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101937/ --- Review request for Calligra. Summary --- Currently all tool actions a

Re: [calligra] libs/kotext/styles: Fix saving line-height to ODF. Just because the property exists doesn't mean it's valid.

2011-07-12 Thread Pierre
On Tuesday 12 July 2011 14:17:12 Sebastian Sauer wrote: > Pierre wrote: > > On Friday 08 July 2011 18:51:17 Sebastian Sauer wrote: > >> Git commit 9f017cf21d343c1408214499bd878b987d8daf6f by Sebastian Sauer. > >> Committed on 08/07/2011 at 18:43. > >> Pushed by sebsauer into branch 'master'. > >>

Re: Review Request: Stage: GSoC: New GUI for manage custom slide shows

2011-07-12 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101820/ --- (Updated July 12, 2011, 8:28 p.m.) Review request for Calligra. Changes

Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-12 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101873/#review4657 --- libs/flake/KoSubpath.h

Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-12 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101873/#review4656 --- Great work, please find attached some comments from myself. li

Re: Review Request: Return support for clone layers of group layers

2011-07-12 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101928/ --- (Updated July 12, 2011, 4:38 p.m.) Review request for Calligra. Changes

Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-12 Thread Lukáš Tvrdý
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101873/ --- (Updated July 12, 2011, 3:59 p.m.) Review request for Calligra, Jan Hambre

Re: Review Request: Return support for clone layers of group layers

2011-07-12 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101928/#review4650 --- There is one old problem in KisNodeManager (will be revealed by

Re: Review Request: Return support for clone layers of group layers

2011-07-12 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101928/#review4642 --- I see one case where it breaks. Consider the following layers:

Re: [calligra] libs/kotext/styles: Fix saving line-height to ODF. Just because the property exists doesn't mean it's valid.

2011-07-12 Thread Sebastian Sauer
Pierre wrote: > On Friday 08 July 2011 18:51:17 Sebastian Sauer wrote: >> Git commit 9f017cf21d343c1408214499bd878b987d8daf6f by Sebastian Sauer. >> Committed on 08/07/2011 at 18:43. >> Pushed by sebsauer into branch 'master'. >> >> Fix saving line-height to ODF. Just because the property exists d

Review Request: Return support for clone layers of group layers

2011-07-12 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101928/ --- Review request for Calligra. Summary --- Also add checking if clone l