Re: Trying to review Calligra

2011-06-23 Thread Boudewijn Rempt
On Thursday 23 June 2011 Jun, Jesse Smith wrote: > Hello Calligra developers, > > I'm writing for two reasons. First up, I'm hoping to do a review of > Calligra to let the open source community know more about your work. And > second I'm having some trouble getting Calligra installed. I'm running

Re: Review Request: some small performance improvements in plugins

2011-06-23 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101736/#review4110 --- Ship it! Looks good .Thanks! - Sebastian On June 23, 2011, 7

Re: Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-23 Thread Jaime Torres Amate
> On June 23, 2011, 9:47 a.m., Matus Uzak wrote: > > Please revert the changes committed to both ParsedPresentation.cpp and > > ODrawToOdf.cpp, check the definition of IOException in libmso. Done. Sorry I forgot to write the tag in the commit. I'll use kdevelop instead of kate. Detecting this

Re: krita shape selection strategy

2011-06-23 Thread Dag Andersen
Tirsdag 21 juni 2011 20:13:14 skrev Cyrille Berger Skott: > On Tuesday 21 June 2011, Dag Andersen wrote: > > It seems krita has its own shape selection strategy. > > When editing one shape, clicking on a different shape selcets the new > > shape activating the interaction tool, so one has to double

Re: Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-23 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/#review4089 --- Please revert the changes committed to both ParsedPresentation.c

Re: best unittest result ever:

2011-06-23 Thread Jos van den Oever
On Wednesday, June 22, 2011 23:42:02 PM Marijn Kruisselbrink wrote: > On Wednesday, June 22, 2011 02:32:21 pm Jos van den Oever wrote: > > On Wednesday, June 22, 2011 23:25:55 PM Jos van den Oever wrote: > > > On Wednesday, June 22, 2011 23:13:40 PM Jos van den Oever wrote: > > > > On Wednesday, Ju

Review Request: some small performance improvements in plugins

2011-06-23 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101736/ --- Review request for Calligra. Summary --- prefix ++ for non trivial ty