Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
On Friday, June 10, 2011 08:43:58 AM Pierre wrote: > That is a really interesting solution. The biggest trick would be not to > forget to delete the objects at the right time if the endElement stays in > the destructor. > But I'm not sure how it would interact with the change tracking code, > unles

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
On Friday, June 10, 2011 08:42:46 AM Thorsten Zachmann wrote: > Hello, > > On Friday, June 10, 2011 08:22:04 Jos van den Oever wrote: > > Here is an idea to improve code quality in Calligra. > > > > Currently, we use KoXmlWriter to write ODF XML. For this, functions like > > startElement, endElem

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
On Friday, June 10, 2011 08:30:36 AM Pierre Stirnweiss wrote: > I like the idea. > On the headerWriter example you give, the end-element is written when the > Writer gets out of scope. We'd need to verify that all our start/end > element couples are within the same scope however. Yes, i did this o

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Thorsten Zachmann
Hello, On Friday, June 10, 2011 08:22:04 Jos van den Oever wrote: > Here is an idea to improve code quality in Calligra. > > Currently, we use KoXmlWriter to write ODF XML. For this, functions like > startElement, endElement, addAttribute are used. > > By using the Relax NG schema, we could gene

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Pierre
On Friday 10 June 2011 08:22:04 Jos van den Oever wrote: > Here is an idea to improve code quality in Calligra. > > Currently, we use KoXmlWriter to write ODF XML. For this, functions like > startElement, endElement, addAttribute are used. > > By using the Relax NG schema, we could generate a wra

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Pierre Stirnweiss
I like the idea. On the headerWriter example you give, the end-element is written when the Writer gets out of scope. We'd need to verify that all our start/end element couples are within the same scope however. Pierre On Fri, Jun 10, 2011 at 8:22 AM, Jos van den Oever < jos.van.den.oe...@kogmbh.

Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Jos van den Oever
Here is an idea to improve code quality in Calligra. Currently, we use KoXmlWriter to write ODF XML. For this, functions like startElement, endElement, addAttribute are used. By using the Relax NG schema, we could generate a wrapper around this class which would give us functions like TextPWr

Review Request: Stage: GSoC: Integrate standard edit actions in Slides Sorter

2011-06-09 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101562/ --- Review request for Calligra. Summary --- Integrate the following stan

Snapshot 2 tagging tomorrow

2011-06-09 Thread Cyrille Berger Skott
Hi, Tomorrow is tagging day for the snapshot 2, so please avoid big merges. -- Cyrille Berger Skott ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: review-request: Fix invalid data-pointer in the msword-filter (2)

2011-06-09 Thread Sebastian Sauer
On Wednesday 08 June 2011 22:37:13 Sebastian Sauer wrote: > Please find attached a patch that fixes bug 275204. The reason for the bug > was that we where ending with random values cause what could work but > sometimes didn't. The values where random cause we dealed with mem past > the allocated nu

Re: KDE git workflow

2011-06-09 Thread Cyrille Berger Skott
On Thursday 09 June 2011, Pierre Stirnweiss wrote: > Any help needed in setting up a windows buildbot (if at all possible)? Definitely possible. And what I am currently doing, should make it possible to prevent migration to "master-validated" if there are errors on windows. -- Cyrille Berger Sko

Re: KDE git workflow

2011-06-09 Thread Pierre Stirnweiss
On Thu, Jun 9, 2011 at 1:13 PM, Cyrille Berger wrote: > On Wed, Jun 08, 2011 at 11:01:13PM +0200, Jos van den Oever wrote: > > On Wednesday, June 08, 2011 21:18:49 PM Pierre Stirnweiss wrote: > > > Well, sounds really really familiar. They could have attended our > sprint > > > and spared the dis

Re: KDE git workflow

2011-06-09 Thread Cyrille Berger
On Wed, Jun 08, 2011 at 11:01:13PM +0200, Jos van den Oever wrote: > On Wednesday, June 08, 2011 21:18:49 PM Pierre Stirnweiss wrote: > > Well, sounds really really familiar. They could have attended our sprint > > and spared the discussion time, couldn't they? ;) > > IIRC this very workflow was al

Re: reviewrequest

2011-06-09 Thread Arjen Hiemstra
On Monday 06 June 2011 13:31:55 Boudewijn Rempt wrote: > > Another note: some of our code uses namespaces, we started to use > > Calligra namespace too. How about removing Ko prefix and have Calligra > > for public libs, and optionally {appname} for apps (if app maintainer > > agrees)? > > Well, I

Re: reviewrequest

2011-06-09 Thread Boudewijn Rempt
On Monday 06 June 2011 Jun, Boudewijn Rempt wrote: > On Monday 06 June 2011 Jun, Burkhard Lück wrote: > > Am Montag, 6. Juni 2011, um 21:29:11 schrieb Boudewijn Rempt: > > > On Monday 06 June 2011 Jun, Burkhard Lück wrote: > > > > Am Montag, 6. Juni 2011, um 12:31:18 schrieb Boudewijn Rempt: > > >