Re: Remove Zoom-submenu from mainmenu?

2011-05-25 Thread C. Boemann
On Thursday 26 May 2011 02:56:54 Sebastian Sauer wrote: > Hi, > > please see attached patch which removes the zoom-submenu from all Calligra > applications. The reason is that it's redundant with the zoom-menu we have > in the statusbar. > > Good idea or not? I think https://git.reviewboard.kde.o

Remove Zoom-submenu from mainmenu?

2011-05-25 Thread Sebastian Sauer
Hi, please see attached patch which removes the zoom-submenu from all Calligra applications. The reason is that it's redundant with the zoom-menu we have in the statusbar. Good idea or not? diff --git a/braindump/data/braindumpview.rc b/braindump/data/braindumpview.rc index 999c949..2f6f59c 100

Review-request: Fix copy+paste sections (bug 271029)

2011-05-25 Thread Sebastian Sauer
The problem is that on copy+paste text in Words we create ODF ouf of a fragment. That fragment can contains SectionEnd's without SectionStart's (or the other way around which would probably produce invalid XML? That case is not handled with this patch :-/ ). That results then in an assert. See b

Re: Random failures in the test kotext-odf-TestChangeTracking

2011-05-25 Thread C. Boemann
Hi Ganesh thanks for the analysis. I guess I'm partly at fault then. I blame git too ;) I'll try and see if i can restore it to working order big thanks Casper On Wednesday 25 May 2011 19:10:03 Ganesh Paramasivam wrote: > Casper, > > I just took a quick look at this and here is the analysis >

Re: Random failures in the test kotext-odf-TestChangeTracking

2011-05-25 Thread Ganesh Paramasivam
Casper, I just took a quick look at this and here is the analysis - A vast majority ( all ? ) of the test failures are due to failures in saving delete changes. - According to the original code, deleted fragments are inserted into the document before a save and removed after a save. - The code to

Re: Random failures in the test kotext-odf-TestChangeTracking

2011-05-25 Thread C. Boemann
Hi Ganesh As soon as possible. We have seen a lot of issues with the changetracking to the point of us regretting that we have merged it into master. It's too late to revert it now, but getting things fixed has a very high priority. best regards Casper On Wednesday 25 May 2011 17:38:20 Ganesh

Re: Random failures in the test kotext-odf-TestChangeTracking

2011-05-25 Thread Ganesh Paramasivam
Casper, I have been on travel on haven't had a chance to look ( also the situation is going to be same for the next 10 days ). If you could give me a target date by when you would like to see this fixed, I will squeeze some time to fix this. Thanks, Ganesh On Wed, May 25, 2011 at 9:03 PM, C. Boe

Re: Random failures in the test kotext-odf-TestChangeTracking

2011-05-25 Thread C. Boemann
Hi is this still an issue and, Ganesh have you had a chance to look. best regards Casper On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote: > Hi, > > Looks like saving of delete changes in broken ( and probably not > related to the random failures ). Will take a look at it. > Can this wai

Re: Review Request: load missing translation catalog for thesaurus plugin

2011-05-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/#review3509 --- This review has been submitted with commit 14c5bab51941a0eb697a

Re: Review Request: load missing translation catalog for thesaurus plugin

2011-05-25 Thread Burkhard Lück
> On May 25, 2011, 9:58 a.m., Casper Boemann wrote: > > No idea wat it does, but I say ship it Whith K_EXPORT_PLUGIN( ThesaurusPluginFactory("ThesaurusPlugin") ) the plugin tries to load the translation catalog "ThesaurusPlugin", but this fails cause the strings are extracted to a catalog name

Re: Review Request: load missing translation catalog for thesaurus plugin

2011-05-25 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/#review3504 --- No idea wat it does, but I say ship it - Casper On May 25, 20

Review Request: load missing translation catalog for thesaurus plugin

2011-05-25 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/ --- Review request for Calligra. Summary --- load translation catalog to