Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Inge Wallin
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > libs/odf/KoEmbeddedFileSaver.cpp, line 82 > > > > > > any reason to make the number at least 4 chars long? It just felt right. > On Feb. 13, 2011, 5:09 a.m

Re: Notes on using Stage

2011-02-12 Thread Thorsten Zachmann
On Monday, February 07, 2011 09:39:25 Boudewijn Rempt wrote: > Hi, > > As you all know, I gave a presentation on Calligra at Fosdem yesterday. > There wasn't much audience at 16:00 on a Sunday afternoon, so there's > wasn't much response from the audience. But at least nobody heckled me > over the

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1398 --- I have created a presentation containing an embedded text docume

invalid odf

2011-02-12 Thread Thorsten Zachmann
Hello Casper, while testing ingwas unavail patch I found out that we produce invalid odf. The code that creates the invalid odf was added by the follwoing commit. eb81a367(Casper Boemann 2010-12-28 13:20:39 +0100 1823) context.xmlWriter().addAttribute("style:wrap", value);

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > Please implement the comments and post for review again. I have not yet done a functional testing bug that will follow. - Thorsten --- This is an automatically generated e-mail

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1396 --- Please implement the comments and post for review again. brain

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1377 --- Can you please wait before committing I would like to review and

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100462/#review1384 --- I suggest that if http://git.reviewboard.kde.org/r/100640/is pos

Review Request: Refactoring of koabstraction lib

2011-02-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100640/ --- Review request for Calligra, Boudewijn Rempt and Mani Chandrasekar. Summar

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100462/#review1379 --- Now final (?) fixes pushed to tools-koabstraction_refactoring1-s

Re: Release plan

2011-02-12 Thread Cyrille Berger Skott
On Saturday 12 February 2011, Alfredo Beaumont wrote: > Larunbata 12 Otsaila 2011(e)an, Boudewijn Rempt(e)k idatzi zuen: > > On Saturday 12 February 2011, Cyrille Berger Skott wrote: > > > Hi, > > > > > > I have updated our release plan: > > > > > > http://community.kde.org/Calligra/Schedules/2.4

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-12 Thread Boudewijn Rempt
On Thursday 10 February 2011, Jaroslaw Staniek wrote: > FYI > The refactoring is mostly done (compiles), so now it'll be tested. > > http://community.kde.org/Calligra/Libs/KoAbstraction#Refactoring > One thing I'm running into right now (I'm trying to make it possible to close FreOffice and to

Re: Release plan

2011-02-12 Thread Alfredo Beaumont
Larunbata 12 Otsaila 2011(e)an, Boudewijn Rempt(e)k idatzi zuen: > On Saturday 12 February 2011, Cyrille Berger Skott wrote: > > Hi, > > > > I have updated our release plan: > > > > http://community.kde.org/Calligra/Schedules/2.4/Release_Plan > > > > Since we want to label our snapshot "stable",

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/#review1374 --- Ship it! I'm not totally happy with having to add code to so ma

Re: Release plan

2011-02-12 Thread Boudewijn Rempt
On Saturday 12 February 2011, Cyrille Berger Skott wrote: > Hi, > > I have updated our release plan: > > http://community.kde.org/Calligra/Schedules/2.4/Release_Plan > > Since we want to label our snapshot "stable", what should we do with failing > unit tests ? Apart from whipping developers un