Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-01 Thread Jaroslaw Staniek
On 2 February 2011 08:48, Boudewijn Rempt wrote: > On Wednesday 02 February 2011, Pierre Stirnweiss wrote: >> I might be missing something, but I thought we decided that in-source >> building would not get supported in Calligra. Why is it necessary for >> Calligra mobile?, Why the exception? >> I

Re: Review Request:

2011-02-01 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100522/#review1152 --- it looks okay to me. i noted a few TODOs that you might want to

Re: Porting code from Calligra to KWord

2011-02-01 Thread Boudewijn Rempt
On Wednesday 02 February 2011, C. Boemann wrote: > Well i would have liked to actually release it first before it being copied, > but it's free software so not much I can do about it Ganesh's patches for kword aren't integrated yet -- it's a separate tree. And I somehow doubt that it'll be easy

Re: Porting code from Calligra to KWord

2011-02-01 Thread Jaroslaw Staniek
On 2 February 2011 05:48, Ganesh Paramasivam wrote: > All, > > For completing the UI for change-tracking of tables for both Calligra > Words and KWord, I need table editing to work on both the > applications. Table editing currently is available in Calligra but not > in KWord. So I will be taking

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-01 Thread Boudewijn Rempt
On Wednesday 02 February 2011, Pierre Stirnweiss wrote: > I might be missing something, but I thought we decided that in-source > building would not get supported in Calligra. Why is it necessary for > Calligra mobile?, Why the exception? > I think that if it is not absolutely necessary to build in

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-01 Thread Pierre Stirnweiss
I might be missing something, but I thought we decided that in-source building would not get supported in Calligra. Why is it necessary for Calligra mobile?, Why the exception? I think that if it is not absolutely necessary to build in source, then we should drop the possibility and have only out o

Re: Porting code from Calligra to KWord

2011-02-01 Thread C. Boemann
Well i would have liked to actually release it first before it being copied, but it's free software so not much I can do about it On Wednesday 02 February 2011 05:48:13 Ganesh Paramasivam wrote: > All, > > For completing the UI for change-tracking of tables for both Calligra > Words and KWord, I

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-01 Thread Mani N C
Hello All, I need your comments/Inputs for the possible solutions, 1. Write a Wrapper class for KoAbstractApplicationController which would have all the slots and signals in it and Child(MainWindow) can create a object of the wrapper and connect the signals to it. 2. Remove QMainWindow inheritan

Review Request:

2011-02-01 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100522/ --- Review request for Calligra. Summary --- This patch implements text o

Porting code from Calligra to KWord

2011-02-01 Thread Ganesh Paramasivam
All, For completing the UI for change-tracking of tables for both Calligra Words and KWord, I need table editing to work on both the applications. Table editing currently is available in Calligra but not in KWord. So I will be taking this code from Calligra master branch and porting to KWord. I wi

Review Request: Switch tool actions on tool change

2011-02-01 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100508/ --- Review request for Calligra. Summary --- Currently there is a problem

Re: Review Request: Send progress updates more frequently

2011-02-01 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/#review1140 --- Ship it! - Boudewijn On Feb. 1, 2011, 4:01 a.m., Thorsten Zac

Re: Git policy: git merge or git cherry-pick

2011-02-01 Thread Lukast dev
> git checkout master > git merge flake-odf-gluepoints... > git pull --rebase > git push > > Ciao Jan Thanks Jan. I also did "git merge --log" with the branch with TOC feature. That --log was suggested by boud, it shows more verbose commit message. For the nice commit message you need to commit

Re: Git policy: git merge or git cherry-pick

2011-02-01 Thread Cyrille Berger Skott
On Monday 31 January 2011, ja...@gmx.net wrote: > But there were problems with the anongit out of sync with git.kde.org. When this happen, wait a few minutes and try pushing again. There is about one minute synchronization delay, between anongit and git.kde.org. So if you are unlucky, someone mig