Re: Review Request: Complete support for ODF glue points

2011-01-27 Thread Jan Hambrecht
> On Jan. 27, 2011, 5:53 a.m., Thorsten Zachmann wrote: > > libs/flake/KoConnectionPoint.h, line 80 > > > > > > The point are not stored in shape coordinates but in percentage value > > of the size How it is stored i

Re: Review Request: Complete support for ODF glue points

2011-01-27 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100447/ --- (Updated Jan. 27, 2011, 11:08 p.m.) Review request for Calligra. Changes

Re: Review Request: Complete support for ODF glue points

2011-01-27 Thread Jan Hambrecht
> On Jan. 27, 2011, 6:23 a.m., Thorsten Zachmann wrote: > > Some things I notices when testing > > > > -I'm did not find out on how to create new connections between shapes. > > -When clicking on a connection point to select it the options are disabled > > > > Your patch fixes bug 251529 > > >

Re: Review Request: Actions for tools

2011-01-27 Thread Cyrille Berger Skott
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100446/#review1092 --- Ship it! looks good ! - Cyrille On Jan. 26, 2011, 7:34 p.m.,

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
> > > > Anyway there will not be that much interaction between the layout and > loading. > So I guess we could make it into a separate text-layout library. But first > I > would like a usecase of someone not wanting the full blown layout after > having > loaded everything into a library that loads

Re: crash in progress updater

2011-01-27 Thread Boudewijn Rempt
On Thu, 27 Jan 2011, Dag Andersen wrote: > [KCrash Handler] > #4 KoProgressUpdater::startSubtask (this=0x0, weight=1, name=...) at > /opt.kde/src/kdesvn/calligra/libs/main/KoProgressUpdater.cpp:130 Well, somehow the progressupdater isn't created when the code follows this path. But that's done

crash in progress updater

2011-01-27 Thread Dag Andersen
Sometimes get a crash (twice so far, no pattern) with the same backtrace. Does anybody have an idea? Application: Plan (kplato), signal: Segmentation fault [Current thread is 1 (Thread 0x7f937e9a5780 (LWP 9))] Thread 3 (Thread 0x7f936031e700 (LWP 11120)): #0 0x7f9378669203 in __poll (fds

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread C. Boemann
On Thursday 27 January 2011 11:49:40 Pierre Stirnweiss wrote: > > Well as i said it's going to be abstracted away, and we are creating a > > layout > > engine for ODF after all. Meaning that a lot of the layout is quite > > specified > > how should look. > > If all a user wants is layout of text,

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
> > Well as i said it's going to be abstracted away, and we are creating a > layout > engine for ODF after all. Meaning that a lot of the layout is quite > specified > how should look. If all a user wants is layout of text, then kotext is handly > a match anyway. And yes there might be a little ov

Re: GSoC 2011!

2011-01-27 Thread Boudewijn Rempt
On Thursday 27 January 2011, Franz Glauber wrote: > I have a question about it! > > Can I apply as a student even if I'm not a student anymore? (I never > participated no GSoC) I'm afraid not -- you really need to be a student at an institute of higher education (university, polytech). -- Boud

Re: GSoC 2011!

2011-01-27 Thread Franz Glauber
I have a question about it! Can I apply as a student even if I'm not a student anymore? (I never participated no GSoC) On Mon, Jan 24, 2011 at 10:44 AM, Cyrille Berger Skott wrote: > Hey, > > Since GSoC 2011 has been announced, time to fill the ideas page: > > http://community.kde.org/GSoC/2011/

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread C. Boemann
On Thursday 27 January 2011 11:15:22 Pierre Stirnweiss wrote: > On Thu, Jan 27, 2011 at 10:51 AM, C. Boemann wrote: > > Well this is a step on the road and not the end result. So bear with me. > > > > But I've indeed changed my mind about who does the layout and drawing, > > and have come up with

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
On Thu, Jan 27, 2011 at 10:51 AM, C. Boemann wrote: > Well this is a step on the road and not the end result. So bear with me. > > But I've indeed changed my mind about who does the layout and drawing, and > have come up with an abstraction that will allow the kotext library to do > just > that.

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread C. Boemann
Well this is a step on the road and not the end result. So bear with me. But I've indeed changed my mind about who does the layout and drawing, and have come up with an abstraction that will allow the kotext library to do just that. Well totally controlled by the textshape. This abstraction will

Re: Review Request: Moving anchor strategy into text shape

2011-01-27 Thread Pierre Stirnweiss
Sorry to arrive after the battle, but I still would like to give an opinion on this one. I don't think this change is going in the right direction. It mixes responsibilities between kotext lib/textshape/application even more. I think we should have a clear separation of responsibilities: kotext li