Re: JDK 16 RFR of JDK-8235496 : "Start of release updates for JDK 16" and related work

2020-05-29 Thread Magnus Ihse Bursie
On 2020-05-28 23:51, Joe Darcy wrote: Hello, The start of JDK 16 is right around the corner with JDK 15 forking off from jdk/jdk at ramp down 1 [1]. Please review the usual build-related portions of     http://cr.openjdk.java.net/~darcy/8235496.4/ Looks good to me. How big is MAX_RADIX,

Re: RFR: 8216303: JFR: Simplify generated files

2020-05-29 Thread Erik Gahlin
Thanks for the reviews. Erik > On 28 May 2020, at 22:55, Erik Joelsson wrote: > > > On 2020-05-28 13:51, Erik Gahlin wrote: >> Hello Erik, >> >>> On 28 May 2020, at 19:47, Erik Joelsson wrote: >>> >>> Hello Erik, >>> >>> I noticed that you added an import for java.util.HashSet, but it does

Re: RFR(S) : 8245610 : remove in-tree copy on gtest

2020-05-29 Thread René Schünemann
Hi all, I agree with Thomas. I think it would be beneficial to have a fallback when there is no gtest directory explicitly set. Also, running make target "run-test-gtest" now without "--with-gtest" results in a not so descriptive error message. make run-test-gtest Building target 'run-test-gtest

Re: JDK 16 RFR of JDK-8235496 : "Start of release updates for JDK 16" and related work

2020-05-29 Thread Jan Lahoda
MAX_RADIX is 36, so this is about 20 more releases, i.e. about 10 years from now. Jan On 29. 05. 20 8:59, Magnus Ihse Bursie wrote: On 2020-05-28 23:51, Joe Darcy wrote: Hello, The start of JDK 16 is right around the corner with JDK 15 forking off from jdk/jdk at ramp down 1 [1]. Please

Re: JDK 16 RFR of JDK-8235496 : "Start of release updates for JDK 16" and related work

2020-05-29 Thread Mario Torre
There seems to be a misaligned filed RELEASE_15: * @since 15 */ - RELEASE_15; +RELEASE_15, + +/** + * The version recognized by the Java Platform, Standard Edition + * 16. + * + * @since 16 + */ + RELEASE_16; On Thu, May 28, 2020 at 11:51 PM Joe Da

RFR: 8245832 - JDK build make-static-libs should build all JDK libraries

2020-05-29 Thread Bob Vandette
Please review this change that alters the make target “make-static-libs” to produce static libraries for ALL native libraries in the JDK. Prior to this fix we only built a small select list. Note: I had to change the functions JAWT_GetAWT for all platforms to match the prototype which used _J

Re: RFR: 8245832 - JDK build make-static-libs should build all JDK libraries

2020-05-29 Thread Erik Joelsson
Looks good. /Erik On 2020-05-29 10:07, Bob Vandette wrote: Please review this change that alters the make target “make-static-libs” to produce static libraries for ALL native libraries in the JDK. Prior to this fix we only built a small select list. Note: I had to change the functions JAWT_

Re: JDK 16 RFR of JDK-8235496 : "Start of release updates for JDK 16" and related work

2020-05-29 Thread Joe Darcy
Hi Mario, On 5/29/2020 8:24 AM, Mario Torre wrote: There seems to be a misaligned filed RELEASE_15: Will be fixed in the next iteration; thanks, -Joe

Re: JDK 16 RFR of JDK-8235496 : "Start of release updates for JDK 16" and related work

2020-05-29 Thread Joe Darcy
Alignment fixed in     http://cr.openjdk.java.net/~darcy/8235496.5/ and the JDK 15 reference build updated to b25. Thanks, -Joe On 5/29/2020 4:27 PM, Joe Darcy wrote: Hi Mario, On 5/29/2020 8:24 AM, Mario Torre wrote: There seems to be a misaligned filed RELEASE_15: Will be fixed in the