RFR: JDK-8067759 Test bundles

The ability to build (when applicable) and bundle the tests that are in the JDK source code at the same time as the product is built is needed. (JDK-8067759) This change provides basic infra structure for creating a test image and bundling it in the same manner as other images/bundles No tes

Re: RFR: JDK-8067759 Test bundles

Looks good to me. /Erik On 2015-01-09 13:24, Ingemar Aberg wrote: The ability to build (when applicable) and bundle the tests that are in the JDK source code at the same time as the product is built is needed. (JDK-8067759) This change provides basic infra structure for creating a test image

Re: RFR: JDK-8067759 Test bundles

On 2015-01-09 13:24, Ingemar Aberg wrote: The ability to build (when applicable) and bundle the tests that are in the JDK source code at the same time as the product is built is needed. (JDK-8067759) This change provides basic infra structure for creating a test image and bundling it in the s

RFR: JDK-8067479: verify-modules fails in bootcycle build

Hello, Please review this patch which fixes the verify-modules target when running bootcycle build, and also reenables verify-modules when running "make images". There were two problems: * The bootcycle build configuration was broken so that both the normal and the bootcycle build used the

Re: RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

On 2015-01-08 15:55, Erik Joelsson wrote: Hello, Please review this patch, which adds support for building with different versions of Visual Studio and in particular adds support for VS2013. In order to control which version to use, I've introduced a new configure parameter "--with-toolchain-

RFR: JDK-8068726: Tab completion of targets fails when current dir is the output dir

Hello, Please review this minor fix. Tab completion stopped working when running make from the output dir (which I often do). I found that this fixed the problem: diff -r ef5c7075496d Makefile --- a/Makefile +++ b/Makefile @@ -54,8 +54,11 @@ # Duplication of global targets, needed before P

Re: RFR: JDK-8067479: verify-modules fails in bootcycle build

On 2015-01-09 15:34, Erik Joelsson wrote: Hello, Please review this patch which fixes the verify-modules target when running bootcycle build, and also reenables verify-modules when running "make images". There were two problems: * The bootcycle build configuration was broken so that both th

Re: RFR: JDK-8068726: Tab completion of targets fails when current dir is the output dir

On 2015-01-09 16:04, Erik Joelsson wrote: Hello, Please review this minor fix. Tab completion stopped working when running make from the output dir (which I often do). I found that this fixed the problem: diff -r ef5c7075496d Makefile --- a/Makefile +++ b/Makefile @@ -54,8 +54,11 @@ # Dup

RFR: JDK-8068735 Configure fails on Windows if Visual Studio $LIB/$INCLUDE is lower case

When detecting the Visual Studio environment, we check for the variables $LIB and $INCLUDE. However, on Windows, environment variables are not case sensitive. Most of the time, these are named $LIB and $INCLUDE, but sometimes they are named $lib and $include instead. Currently, we fail if this

Re: RFR: JDK-8068735 Configure fails on Windows if Visual Studio $LIB/$INCLUDE is lower case

Looks ok to me. /Erik On 2015-01-09 16:41, Magnus Ihse Bursie wrote: When detecting the Visual Studio environment, we check for the variables $LIB and $INCLUDE. However, on Windows, environment variables are not case sensitive. Most of the time, these are named $LIB and $INCLUDE, but sometim

Re: RFR: JDK-8067060: build can still fail with spaces following -L on link lines

On 2014-12-10 12:30, Erik Joelsson wrote: Hello, Embarrassingly enough, my last fix for the -L and space problem wasn't correct. Here is a new fix where I'm reverting the macro definitions from using define to simple = assignment. The latter automatically strips leading whitespace and IMO fit

De-universalizing hotspot in jdk8u

We have this nice little comment in common/autoconf/jdk-options.m4: # On Macosx universal binaries are produced, but they only contain # 64 bit intel. This invalidates control of which jvms are built # from configure, but only server is valid anyway. Fix this # when hotspot makefiles are r

Re: JDK 9 RFR of JDK-8067099: Add deprecation lint warning to build of jdk repository

Hello, Catching up on email after the holidays... On 12/9/2014 10:39 PM, Erik Joelsson wrote: First, congratulations on almost being done fixing all the warnings! When removing the last warning exception, perhaps it's time to change the comment next to this line too? A fair point! How abo

[8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

Please review the open source changes for 8043340. The goal here is to get jdk8u to build on Mac OS X 10.9+ systems where Xcode 5+ and Xcode 4 are co-installed, a configuration which is becoming more and more commonplace as more developers are focusing on JDK 9 now (which needs Xcode 5 installe