Re: RFR: JDK 8047933 Race between jdk/make/scripts/genExceptions.sh and com.sun.tools.javadoc.Main

2014-09-23 Thread Magnus Ihse Bursie
On 2014-09-23 04:27, Tim Bell wrote: Please review a small change to make/Main.gmk https://bugs.openjdk.java.net/browse/JDK-8047933 http://cr.openjdk.java.net/~tbell/8047933/webrev.00/ Thanks to Erik Joelsson for the suggested fix. Thanks in advance- Looks good to me. /Magnus

Re: RFR: JDK-8058845 : Update JCE environment for build improvements

2014-09-23 Thread Alan Bateman
On 21/09/2014 23:51, Bradford Wetmore wrote: Hi Sean/Mandy/Erik/Magnus/Alan/David/others, Please review: JDK-8058845 : Update JCE environment for build improvements http://cr.openjdk.java.net/~wetmore/8058845/ This change is to alleviate some of the overly-complicated steps we (Oracl

Re: RFR: JDK-8058845 : Update JCE environment for build improvements

2014-09-23 Thread Mandy Chung
On 9/21/14 3:51 PM, Bradford Wetmore wrote: Hi Sean/Mandy/Erik/Magnus/Alan/David/others, Please review: JDK-8058845 : Update JCE environment for build improvements http://cr.openjdk.java.net/~wetmore/8058845/ The change looks fine in general. Some minor comments: javax/crypto/Ciph

RFR : 8059000 : hgforest: pass options to serve command

2014-09-23 Thread Mike Duigou
Hello all; This is a one line change to the hgforest command to pass the command line options to the serve command. This is mostly useful for passing --port option https://bugs.openjdk.java.net/browse/JDK-8059000 Mike diff --git a/common/bin/hgforest.sh b/common/bin/hgforest.sh --- a/common/bi