Re: RFR (XS) 8033946 - Hotspot build should ignore "ide" folder

2014-09-09 Thread Magnus Ihse Bursie
On 2014-09-04 18:45, Gerard Ziemski wrote: hi all, Please review a very small fix that makes hotspot build ignore "ide" folder, which is where local users can store their own favorite IDE projects. For those interested, I have an Xcode project for JDK8 and JDK9 that I am personally actively

Re: Qn WRT PACKAGES and FEATURES

2014-09-09 Thread Magnus Ihse Bursie
On 2014-09-08 10:11, Erik Joelsson wrote: On 2014-09-08 03:45, David Holmes wrote: On 6/09/2014 11:20 PM, pointo1d wrote: Hi all , Whilst perusing the output from the command $ bash configure --help, in connection with enabling/disabling parts of the build, I notice the use of the terms FEATU

Re: Qn WRT PACKAGES and FEATURES

2014-09-09 Thread pointo1d
On 09/09/14 12:55, Magnus Ihse Bursie wrote: On 2014-09-08 10:11, Erik Joelsson wrote: On 2014-09-08 03:45, David Holmes wrote: On 6/09/2014 11:20 PM, pointo1d wrote: Hi all , Whilst perusing the output from the command $ bash configure --help, in connection with enabling/disabling parts o

Re: RFR: 8056209 : Remove unused files for libawt

2014-09-09 Thread Magnus Ihse Bursie
On 2014-09-05 18:05, Phil Race wrote: PS i filed https://bugs.openjdk.java.net/browse/JDK-8057711 to track D3DShaderGen.c Thanks! /Magnus

Re: RFR(M): 8057538: Build the freetype library during configure on Windows

2014-09-09 Thread Magnus Ihse Bursie
Hi Volker, Sorry for not responding to this earlier. As I said in the bug, I really like this idea! I have a few comments. I understand why you would have liked to add the ac_executable_extensions stuff, but since you can't due to performance, and that is not likely to change in the future e

Re: Build problems on Jenkins prototypes

2014-09-09 Thread Eric McCorkle
On 08/24/14 20:31, David Holmes wrote: > On 22/08/2014 1:12 AM, Eric McCorkle wrote: >> Possible lead: it seems hotspot/make/defs.make defaults to Windows if it >> doesn't recognize the $OS variable. >> >> 1) It should throw an error in that case >> 2) I checked on Jenkins, and the PATH seems fine,

Re: Build problems on Jenkins prototypes

2014-09-09 Thread Eric McCorkle
Ok, I think I found the problem: In hotspot/make/defs.make, the following lines: # Windows should have OS predefined ifeq ($(OS),) OS := $(shell uname -s) ifneq ($(findstring BSD,$(OS)),) OS=bsd endif ifeq ($(OS), Darwin) OS=bsd endif HOST := $(shell uname -n) endif # If n

RFR: 8056213 : Clean up unix/native/common/sun/awt

2014-09-09 Thread Phil Race
After looking at the issues in the bug report below I think the only think that must be fixed is the unnecessary inclusion of initIDS.c in libawt_xawt.so https://bugs.openjdk.java.net/browse/JDK-8056213 http://cr.openjdk.java.net/~prr/8056213/ I've tested this out on Linux and am submitting a

Re: Build problems on Jenkins prototypes

2014-09-09 Thread Eric McCorkle
More investigation, the hotspot makefile seems to be getting executed with OS set to "linux", with a lower-case ell. That would be the cause of the problem. What I'm not so sure about is why its getting executed that way, or how to fix it. On 09/09/14 16:50, Eric McCorkle wrote: > Ok, I think I

Re: Build problems on Jenkins prototypes

2014-09-09 Thread David Holmes
On 10/09/2014 8:10 AM, Eric McCorkle wrote: More investigation, the hotspot makefile seems to be getting executed with OS set to "linux", with a lower-case ell. That would be the cause of the problem. What I'm not so sure about is why its getting executed that way, or how to fix it. Check if