Re: fopen()-pclose() bug in install-info

2021-02-10 Thread Gavin Smith
On Tue, Feb 09, 2021 at 10:02:47PM +0100, Barath Aron wrote: > On 2/9/21 9:55 PM, Gavin Smith wrote: > > On Tue, Feb 09, 2021 at 09:10:28PM +0100, Barath Aron wrote: > > > The code path I wrote is the trace of the program, I didn't made it up. It > > > first opened a regular, non-compressed file wi

Re: fopen()-pclose() bug in install-info

2021-02-09 Thread Hans-Bernhard Bröker
Am 09.02.2021 um 21:55 schrieb Gavin Smith: > Yes, it is clearly wrong in this case. It's just a question now of > understanding the changes in the two earlier commits and making > sure that we don't break anything that those commits were supposed to > fix. I'm pretty sure it's 2d03d088d945a9dc

Re: fopen()-pclose() bug in install-info

2021-02-09 Thread Barath Aron
On 2/9/21 9:55 PM, Gavin Smith wrote: On Tue, Feb 09, 2021 at 09:10:28PM +0100, Barath Aron wrote: The code path I wrote is the trace of the program, I didn't made it up. It first opened a regular, non-compressed file with fopen() [this was in line 700], then it would freopen()ed [line 882, but

Re: fopen()-pclose() bug in install-info

2021-02-09 Thread Gavin Smith
On Tue, Feb 09, 2021 at 09:10:28PM +0100, Barath Aron wrote: > The code path I wrote is the trace of the program, I didn't made it up. It > first opened a regular, non-compressed file with fopen() [this was in line > 700], then it would freopen()ed [line 882, but it won't make any > difference], th

Re: fopen()-pclose() bug in install-info

2021-02-09 Thread Barath Aron
On 2/9/21 6:11 PM, Gavin Smith wrote: On Fri, Jan 29, 2021 at 01:41:22PM +0100, Barath Aron wrote: Hello, I ran into a bug in the "install-info" program, where the "dir" file is opened with fopen(), and it was closed with pclose(). That's why "install-info" hangs on the OS I use. The path in th

Re: fopen()-pclose() bug in install-info

2021-02-09 Thread Gavin Smith
On Fri, Jan 29, 2021 at 01:41:22PM +0100, Barath Aron wrote: > Hello, > > I ran into a bug in the "install-info" program, where the "dir" file is > opened with fopen(), and it was closed with pclose(). That's why > "install-info" hangs on the OS I use. > The path in the code is clear. > > install

fopen()-pclose() bug in install-info

2021-01-29 Thread Barath Aron
Hello, I ran into a bug in the "install-info" program, where the "dir" file is opened with fopen(), and it was closed with pclose(). That's why "install-info" hangs on the OS I use. The path in the code is clear. install-info/install-info.c: 910: f = open_possibly_compressed_file (...) 700: f