Re: Minor build fixes

2014-10-06 Thread Ken Brown
On 10/6/2014 3:48 PM, Gavin Smith wrote: On Thu, Oct 2, 2014 at 5:46 PM, Ken Brown wrote: I just took over as the Cygwin maintainer of Texinfo, and I bumped into a few (easily fixed) build problems. The first two exist in texinfo-5.2, and the rest only in the trunk. I think that it is them a

Re: Minor build fixes

2014-10-06 Thread Gavin Smith
On Thu, Oct 2, 2014 at 5:46 PM, Ken Brown wrote: > I just took over as the Cygwin maintainer of Texinfo, and I bumped into a > few (easily fixed) build problems. The first two exist in texinfo-5.2, and > the rest only in the trunk. I think that it is them all done now. Please email if any proble

Re: Minor build fixes

2014-10-06 Thread Eli Zaretskii
> Date: Mon, 6 Oct 2014 13:49:44 +0100 > From: Gavin Smith > Cc: Ken Brown , Texinfo > > I am wondering if "sys/ioctl.h" should be added to AC_CHECK_HEADERS in > configure.ac and then the include made conditional on > "HAVE_SYS_IOCTL_H". Probably a good idea.

Re: Minor build fixes

2014-10-06 Thread Gavin Smith
>> >> --- info/termdep.h (revision 5852) >> >> +++ info/termdep.h (working copy) >> >> @@ -49,7 +49,7 @@ >> >> # endif /* !HAVE_TERMIO_H */ >> >> #endif /* !HAVE_TERMIOS_H */ >> >> >> >> -#ifdef GWINSZ_IN_SYS_IOCTL >> >> +#ifndef __MINGW32__ >> >> # include >> >> #endif >> >> >

Re: Minor build fixes

2014-10-03 Thread Ken Brown
On 10/3/2014 2:31 AM, Eli Zaretskii wrote: What about file names with drive letters? Experience (in the GNU Make department) indicates that some Cygwin users want that, perhaps because they use Cygwin tools outside of the Cygwin environment. OK, maybe I shouldn't rock the boat. I'll withdraw

Re: Minor build fixes

2014-10-02 Thread Eli Zaretskii
> Date: Thu, 02 Oct 2014 18:55:29 -0400 > From: Ken Brown > Cc: Texinfo > > On 10/2/2014 6:24 PM, Ken Brown wrote: > > I think it's all OK, but I have to think a little more about comparison of > > file > > names. I'll get back to you on that. > > I'm not sure about comparison of file names,

Re: Minor build fixes

2014-10-02 Thread Eli Zaretskii
> Date: Thu, 02 Oct 2014 18:24:49 -0400 > From: Ken Brown > Cc: Texinfo > > >> -#ifdef GWINSZ_IN_SYS_IOCTL > >> +#ifndef __MINGW32__ > >> # include > >> #endif > >> > > > > I see the same thing (conditional on __MINGW32__) is done when > > including sys/ioctl.h in info/ioctl.h and info/man

Re: Minor build fixes

2014-10-02 Thread Eli Zaretskii
> Date: Thu, 02 Oct 2014 18:24:49 -0400 > From: Ken Brown > Cc: Texinfo > > > If I understand this right, O_BINARY is being checked to see if it is > > a Posix-style system, right, but Cygwin has O_BINARY defined? O_BINARY > > is not actually being set in system.h for the benefit of source code

Re: Minor build fixes

2014-10-02 Thread Ken Brown
On 10/2/2014 6:24 PM, Ken Brown wrote: I think it's all OK, but I have to think a little more about comparison of file names. I'll get back to you on that. I'm not sure about comparison of file names, so maybe it would be safer to use case-insensitive comparison as before. This requires addi

Re: Minor build fixes

2014-10-02 Thread Ken Brown
On 10/2/2014 4:37 PM, Gavin Smith wrote: 1. The compiler produces lots of warnings about setmode being redefined. It would be simple to silence the warnings, but the real issue in my opinion is that Cygwin should be treated the same as Unix, so that there's no need for setmode at all: Index: sy

Re: Minor build fixes

2014-10-02 Thread Gavin Smith
On Thu, Oct 2, 2014 at 5:46 PM, Ken Brown wrote: > I just took over as the Cygwin maintainer of Texinfo, and I bumped into a > few (easily fixed) build problems. The first two exist in texinfo-5.2, and > the rest only in the trunk. Thanks for the report. Comments below: > 1. The compiler produc

Minor build fixes

2014-10-02 Thread Ken Brown
I just took over as the Cygwin maintainer of Texinfo, and I bumped into a few (easily fixed) build problems. The first two exist in texinfo-5.2, and the rest only in the trunk. 1. The compiler produces lots of warnings about setmode being redefined. It would be simple to silence the warnings