Re: Encoding customization variable names

2022-07-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sat, 23 Jul 2022 22:25:08 +0100 > > Here's the current text in the manual: LGTM, thanks.

Re: Encoding customization variable names

2022-07-23 Thread Gavin Smith
On Sat, Jul 23, 2022 at 06:19:45PM +0200, Patrice Dumas wrote: > On Sat, Jul 23, 2022 at 04:25:02PM +0300, Eli Zaretskii wrote: > > Are you saying that Unix systems with non-UTF-8 locales no longer > > exist? Because I'm familiar with several people whose locale on > > GNU/Linux does not use UTF-8

Re: Encoding customization variable names

2022-07-23 Thread Patrice Dumas
On Sat, Jul 23, 2022 at 04:25:02PM +0300, Eli Zaretskii wrote: > Are you saying that Unix systems with non-UTF-8 locales no longer > exist? Because I'm familiar with several people whose locale on > GNU/Linux does not use UTF-8 as the codeset. I am not saying that this does not exist anymore, but

Re: Encoding customization variable names

2022-07-23 Thread Eli Zaretskii
> Date: Sat, 23 Jul 2022 14:15:58 +0200 > From: Patrice Dumas > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > On Sat, Jul 23, 2022 at 09:20:19AM +0300, Eli Zaretskii wrote: > > This should IMO come with a set of recommendations regarding the > > practices: when and for what reasons to ove

Re: Encoding customization variable names

2022-07-23 Thread Patrice Dumas
On Sat, Jul 23, 2022 at 09:20:19AM +0300, Eli Zaretskii wrote: > This should IMO come with a set of recommendations regarding the > practices: when and for what reasons to override the defaults, and > with what recommended values. Otherwise, users of Texinfo will not > necessarily understand the s

Re: Encoding customization variable names

2022-07-22 Thread Eli Zaretskii
> Date: Fri, 22 Jul 2022 22:41:26 +0200 > From: Patrice Dumas > > On Fri, Jul 22, 2022 at 05:55:01PM +0100, Gavin Smith wrote: > > > * Use document encoding > > > * Use locale encoding > > > * Specify encoding explicitly > > > > ... > > > > > I'm going to make a start by stripping out the LOCAL

Re: Encoding customization variable names

2022-07-22 Thread Gavin Smith
On Fri, Jul 22, 2022 at 10:41:26PM +0200, Patrice Dumas wrote: > This looks good to me. I think that the locale encoding should also be > a customization variable, but in the documentation it would be stated that > "You should not need to explicitly set this variable." It is possible > to pass it

Re: Encoding customization variable names

2022-07-22 Thread Patrice Dumas
On Fri, Jul 22, 2022 at 05:55:01PM +0100, Gavin Smith wrote: > > * Use document encoding > > * Use locale encoding > > * Specify encoding explicitly > > ... > > > I'm going to make a start by stripping out the LOCALE_ prefix and then > > have a look to see if something else is needed to give thes

Re: Encoding customization variable names

2022-07-22 Thread Gavin Smith
On Fri, Jul 22, 2022 at 03:07:59PM +0100, Gavin Smith wrote: > I think it's better if variables don't have to be set in combination. > I feel that we could design a better interface. Here's my attempt... > > Options to allow: > * Use document encoding > * Use locale encoding > * Specify encoding

Re: Encoding customization variable names

2022-07-22 Thread Gavin Smith
On Sun, May 29, 2022 at 02:08:42PM +0100, Gavin Smith wrote: > On Fri, Mar 4, 2022 at 7:22 AM Patrice Dumas wrote: > > Also do not hesitate to propose other names for those customization > > variables. > > Still to review: LOCALE_INPUT_FILE_NAME_ENCODING, > LOCALE_OUTPUT_FILE_NAME_ENCODING, DOC_E

Re: Encoding customization variable names

2022-05-31 Thread Patrice Dumas
On Tue, May 31, 2022 at 09:11:21PM +0100, Gavin Smith wrote: > > I've committed the change. Please feel free to make other changes to > complete this. Should be done. -- Pat

Re: Encoding customization variable names

2022-05-31 Thread Gavin Smith
On Mon, May 30, 2022 at 10:32:07PM +0200, Patrice Dumas wrote: > On Mon, May 30, 2022 at 08:04:34PM +0100, Gavin Smith wrote: > > On Mon, May 30, 2022 at 06:43:32PM +0100, Gavin Smith wrote: > > > On Mon, May 30, 2022 at 11:48:22AM +0200, Patrice Dumas wrote: > > > > > > Some tests need this eithe

Re: Encoding customization variable names

2022-05-30 Thread Patrice Dumas
On Mon, May 30, 2022 at 08:04:34PM +0100, Gavin Smith wrote: > On Mon, May 30, 2022 at 06:43:32PM +0100, Gavin Smith wrote: > > On Mon, May 30, 2022 at 11:48:22AM +0200, Patrice Dumas wrote: > > > > Some tests need this either to have expected error messages, or > > > more fundamentaly for input f

Re: Encoding customization variable names

2022-05-30 Thread Gavin Smith
On Mon, May 30, 2022 at 06:43:32PM +0100, Gavin Smith wrote: > On Mon, May 30, 2022 at 11:48:22AM +0200, Patrice Dumas wrote: > > Some tests need this either to have expected error messages, or > > more fundamentaly for input file names decoding. I can propose > > something similar with 'Need rec

Re: Encoding customization variable names

2022-05-30 Thread Gavin Smith
On Mon, May 30, 2022 at 11:48:22AM +0200, Patrice Dumas wrote: > On Sun, May 29, 2022 at 02:08:42PM +0100, Gavin Smith wrote: > > On Fri, Mar 4, 2022 at 7:22 AM Patrice Dumas wrote: > > > Also do not hesitate to propose other names for those customization > > > variables. > > > > Another issue (I

Re: Encoding customization variable names

2022-05-30 Thread Patrice Dumas
On Sun, May 29, 2022 at 02:08:42PM +0100, Gavin Smith wrote: > On Fri, Mar 4, 2022 at 7:22 AM Patrice Dumas wrote: > > Also do not hesitate to propose other names for those customization > > variables. > > Another issue (I can't remember if I emailed you before about this) is > the locale setting

Test locales (was: Re: Encoding customization variable names)

2022-05-29 Thread Jacob Bachmeyer
Gavin Smith wrote: Another issue (I can't remember if I emailed you before about this) is the locale settings to run the test suites. You changed it from "C" to "C.UTF-8", but the latter encoding doesn't exist everywhere. I changed it to "en_US.UTF-8" (see ChangeLog entries on 2022-04-14) but thi

Encoding customization variable names

2022-05-29 Thread Gavin Smith
On Fri, Mar 4, 2022 at 7:22 AM Patrice Dumas wrote: > Also do not hesitate to propose other names for those customization > variables. I've renamed DATA_INPUT_ENCODING_NAME to COMMAND_LINE_ENCODING and LOCALE_OUTPUT_ENCODING_NAME to MESSAGE_ENCODING in an attempt to make them more meaningful and