On Wed, 22 Dec 2021 at 05:42, Gavin Smith wrote:
> On Mon, Nov 22, 2021 at 09:39:02AM +1100, Brendan O'Dea wrote:
> >- One instance of struct spec_entry is not correctly initialised (patch
> >is attached). That doesn't cause problems now as far as I can tell, but
> >doesn't hurt to fi
On Mon, Nov 22, 2021 at 09:39:02AM +1100, Brendan O'Dea wrote:
>- One instance of struct spec_entry is not correctly initialised (patch
>is attached). That doesn't cause problems now as far as I can tell, but
>doesn't hurt to fix.
Thanks, committed in your name in cc4376b915.
On Mon, Nov 22, 2021 at 09:39:02AM +1100, Brendan O'Dea wrote:
> Thanks Gavin, that looks good. valgrind no longer complains about the
> folding.info input, and the output doesn't include garbage.
>
> I've sent a change to the folding-mode maintainer to fix their index:
> https://github.com/jaalt
On Mon, Nov 22, 2021 at 09:39:02AM +1100, Brendan O'Dea wrote:
> Thanks Gavin, that looks good. valgrind no longer complains about the
> folding.info input, and the output doesn't include garbage.
Committed in 39d38dd035.
>- The function extract_menu_file_name is unused, consider removing it
Thanks Gavin, that looks good. valgrind no longer complains about the
folding.info input, and the output doesn't include garbage.
I've sent a change to the folding-mode maintainer to fix their index:
https://github.com/jaalto/project-emacs--folding-mode/pull/9
A couple of other minor nits I noti
On Sun, Nov 21, 2021 at 01:40:13AM +1100, Brendan O'Dea wrote:
> Malformed info files cause install-info to produce corrupted dir files.
>
> See attached example, where the folding info page contains:
>
> START-INFO-DIR-ENTRY
> * folding: folding editor minor mode for Emacs
> END-INFO-DIR-E
Malformed info files cause install-info to produce corrupted dir files.
See attached example, where the folding info page contains:
START-INFO-DIR-ENTRY
* folding: folding editor minor mode for Emacs
END-INFO-DIR-ENTRY
which results in the corrupted `dir` file in the attached archive.
I'm
