Re: [PATCH] install-info: fix delete dir file section code

2023-04-05 Thread John Wheeler
On 3/26/23 13:28, John Wheeler wrote: Attached is a revised patch that addresses your concern.  With this patch deleting a section will remove all preceding blank lines.  This change required changing file ii-0047-expected-dir-file to remove the extra blank line at the end of the file. I added

Re: [PATCH] install-info: fix delete dir file section code

2023-03-26 Thread John Wheeler
On 3/24/23 15:19, John Wheeler wrote: On 3/24/23 14:41, Gavin Smith wrote: Thanks for the detailed instructions on how to replicate this problem.  I agree that the extra blank line being inserted is not a good thing. Could it be fixed by avoiding adding an extra blank line if not needed, rather

[PATCH] install-info: fix delete dir file section code

2023-03-24 Thread John Wheeler
Gavin, I offer the following for your consideration. Thank you, John Wheeler Bug report: Off-by-one flaw in deleting empty dir section Current troublesome behavior: install-info adds a blank line before the final dir file section each time that section is removed and re-installed.  This i

Re: [PATCH] install-info: fix delete dir file section code

2023-03-24 Thread John Wheeler
On 3/24/23 14:41, Gavin Smith wrote: Thanks for the detailed instructions on how to replicate this problem. I agree that the extra blank line being inserted is not a good thing. Could it be fixed by avoiding adding an extra blank line if not needed, rather than by deleting an extra line? With

Re: [PATCH] install-info: fix delete dir file section code

2023-03-24 Thread Gavin Smith
On Fri, Mar 24, 2023 at 12:32:45PM -0500, John Wheeler wrote: > Bug report: Off-by-one flaw in deleting empty dir section > > Current troublesome behavior: install-info adds a blank line > before the final dir file section each time that section is > removed and re-installed.  This is troublesome