Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Eli Zaretskii
> From: Arash Esbati > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > Date: Thu, 06 Apr 2023 20:13:32 +0200 > > Eli Zaretskii writes: > > > Btw, I just built Texinfo 7.0.3, and info.exe still displays Unicode > > quotes as I expect: transliterated to ASCII characters. So why it > > doesn

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Arash Esbati
Eli Zaretskii writes: > Texinfo 7.0.3 doesn't have any inclusions of wait.h, only sys/wait.h, I meant sys/wait.h, sorry. > The latter is guarded by "#if defined (HAVE_SYS_WAIT_H)", and the > former should not be used on MinGW. What problems do you get if > wait.h is not available? make threw

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Eli Zaretskii
> From: Arash Esbati > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > Date: Thu, 06 Apr 2023 14:18:50 +0200 > > Eli Zaretskii writes: > > > Why on Earth is a system header included only in msys2-runtime-devel? > > > > Also, is msys2-runtime-devel about building MSYS2 programs or MinGW > >

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Arash Esbati
Eli Zaretskii writes: > Why on Earth is a system header included only in msys2-runtime-devel? > > Also, is msys2-runtime-devel about building MSYS2 programs or MinGW > programs? If the latter, it shouldn't be needed for your attempts to > build a MinGW port. Sorry, I can't tell if msys2-runtime

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Arash Esbati
Gavin Smith writes: > Indeed, it's not our job to tell developers how to install automake and > the like on various platforms. We already list which programs they need > in README-hacking; I don't see why that isn't enough. Thanks, fine with me. Best, Arash

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Gavin Smith
On Thu, Apr 06, 2023 at 02:58:48PM +0300, Eli Zaretskii wrote: > > That's true, as long as you want to build from a tarball. If you want > > to build from git, you have to install other stuff like: > > > > automake-wrapper > > msys2-runtime-devel > > libtool > > man-db > > help2man > >

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Eli Zaretskii
> From: Arash Esbati > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > Date: Thu, 06 Apr 2023 13:22:46 +0200 > > Eli Zaretskii writes: > > > The only Windows-specific issue I'm aware of is that the 'configure' > > command should point to the native MS-Windows port of Perl, not to the > > M

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Arash Esbati
Eli Zaretskii writes: > The only Windows-specific issue I'm aware of is that the 'configure' > command should point to the native MS-Windows port of Perl, not to the > MSYS Perl. That's true, as long as you want to build from a tarball. If you want to build from git, you have to install other s

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Eli Zaretskii
> From: Arash Esbati > Cc: bug-texinfo@gnu.org > Date: Thu, 06 Apr 2023 08:55:22 +0200 > > I see that Texinfo doesn't have any instructions how to build and install > Texinfo with MinGW64. Should I make a proposal? It depends on what MinGW64-specific nits you think should be there. The only Wi

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-06 Thread Gavin Smith
On Thu, Apr 06, 2023 at 08:55:22AM +0200, Arash Esbati wrote: > Gavin Smith writes: > > > Thanks for sending these. I've committed it. > > Thanks for installing it, and thanks for fixing all the other issues. I > see that Texinfo doesn't have any instructions how to build and install > Texinfo

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Arash Esbati
Gavin Smith writes: > Thanks for sending these. I've committed it. Thanks for installing it, and thanks for fixing all the other issues. I see that Texinfo doesn't have any instructions how to build and install Texinfo with MinGW64. Should I make a proposal? Best, Arash

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Gavin Smith
On Wed, Apr 05, 2023 at 09:46:28AM +0200, Arash Esbati wrote: > Hi all, > > I tried Eli's advice in this message[1] reg. silencing of compiler > warnings about "free" redefined. The change below made them go away: Thanks for sending these. I've committed it. We already had this in some files (

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Eli Zaretskii
> Date: Wed, 5 Apr 2023 11:31:12 +0200 > From: Patrice Dumas > Cc: Arash Esbati , bug-texinfo@gnu.org > > On Wed, Apr 05, 2023 at 11:47:08AM +0300, Eli Zaretskii wrote: > > Those are real bugs: we should cast to inptr_t instead of long. > > We already do that in some code, but we immediatly cast

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Patrice Dumas
On Wed, Apr 05, 2023 at 11:47:08AM +0300, Eli Zaretskii wrote: > Those are real bugs: we should cast to inptr_t instead of long. We already do that in some code, but we immediatly cast to another type, defined in perl, like IV value = (IV) (intptr_t) k->value; Is there a integer type we could c

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Eli Zaretskii
> From: Arash Esbati > Date: Wed, 05 Apr 2023 09:46:28 +0200 > > The only other warnings I get are (linebreaks added manually): > > --8<---cut here---start->8--- > parsetexi/handle_commands.c: In function 'handle_other_command': > parsetexi/handle_commands.c:3

[PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Arash Esbati
Hi all, I tried Eli's advice in this message[1] reg. silencing of compiler warnings about "free" redefined. The change below made them go away: --8<---cut here---start->8--- diff --git a/tp/Texinfo/XS/MiscXS.xs b/tp/Texinfo/XS/MiscXS.xs index a8c58cc539..65b6e