Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Gavin Smith
On Tue, May 20, 2025 at 01:06:38PM -0700, Collin Funk wrote: > Is there any benefit to doing this over just doing: > > $ git am 0001-example-commit.patch > > That command should set the author correctly. > > Collin It's because we keep a ChangeLog file changes to which need to be included i

Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Collin Funk
Hi Gavin and Patrice, Gavin Smith writes: > On Tue, May 20, 2025 at 10:06:17AM +0200, Patrice Dumas wrote: >> Hello, >> >> The analysis and patch look good to me. Gavin, I think that you can >> apply it (I know that it is a kind of patch practical for git to get >> both the patch and commiter r

Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Gavin Smith
On Tue, May 20, 2025 at 10:06:17AM +0200, Patrice Dumas wrote: > Hello, > > The analysis and patch look good to me. Gavin, I think that you can > apply it (I know that it is a kind of patch practical for git to get > both the patch and commiter right, but I don't know how to apply that > kind of

Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Patrice Dumas
t; satisfied the uninitialized pointer is passed to strcmp. > > I have attached a proposed patch. > > Collin > > From a757289836db44501eb667ee222fa48fd5da31a9 Mon Sep 17 00:00:00 2001 > Message-ID: > > From: Collin Funk > Date: Mon, 19 May 2025 18:32:19 -0700

[PATCH] Fix an uninitialized variable.

2025-05-19 Thread Collin Funk
} This warning seems accurate to me, since if the first condition is not satisfied the uninitialized pointer is passed to strcmp. I have attached a proposed patch. Collin >From a757289836db44501eb667ee222fa48fd5da31a9 Mon Sep 17 00:00:00 2001 Message-ID: From: Colli