Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Collin Funk
Hi Gavin and Patrice, Gavin Smith writes: > On Tue, May 20, 2025 at 10:06:17AM +0200, Patrice Dumas wrote: >> Hello, >> >> The analysis and patch look good to me. Gavin, I think that you can >> apply it (I know that it is a kind of patch practical for git to get >> both the patch and commiter r

[PATCH] Fix an uninitialized variable.

2025-05-19 Thread Collin Funk
} This warning seems accurate to me, since if the first condition is not satisfied the uninitialized pointer is passed to strcmp. I have attached a proposed patch. Collin >From a757289836db44501eb667ee222fa48fd5da31a9 Mon Sep 17 00:00:00 2001 Message-ID: From: Colli

Re: using size_t for search bindings in info reader bug hidden versus underflow

2024-10-07 Thread Collin Funk
Hi Patrice, Patrice Dumas writes: > I realized that there was a bug because I had set SEARCH_BINDING start > and end offsets to size_t, which lead s.start becoming the max size_t > value (and to a segfault), I had not seen it while reviewing the code > for such possibilities. > > Keeping long co