Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Gavin Smith
On Tue, May 20, 2025 at 01:06:38PM -0700, Collin Funk wrote: > Is there any benefit to doing this over just doing: > > $ git am 0001-example-commit.patch > > That command should set the author correctly. > > Collin It's because we keep a ChangeLog file changes to which need to be included i

Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Collin Funk
Hi Gavin and Patrice, Gavin Smith writes: > On Tue, May 20, 2025 at 10:06:17AM +0200, Patrice Dumas wrote: >> Hello, >> >> The analysis and patch look good to me. Gavin, I think that you can >> apply it (I know that it is a kind of patch practical for git to get >> both the patch and commiter r

Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Gavin Smith
On Tue, May 20, 2025 at 10:06:17AM +0200, Patrice Dumas wrote: > Hello, > > The analysis and patch look good to me. Gavin, I think that you can > apply it (I know that it is a kind of patch practical for git to get > both the patch and commiter right, but I don't know how to apply that > kind of

Re: "texi2any --html --no-split" should not generate accesskey attributes

2025-05-20 Thread Gavin Smith
> > The following seems to work for the non-XS code: > > > > diff --git a/tta/perl/Texinfo/Convert/HTML.pm > > b/tta/perl/Texinfo/Convert/HTML.pm > > index c68559c7eb..3435405254 100644 > > --- a/tta/perl/Texinfo/Convert/HTML.pm > > +++ b/tta/perl/Texinfo/Convert/HTML.pm > > @@ -9247,6 +9247,13 @

blank lines behavior and documentation

2025-05-20 Thread Vincent Lefevre
Hi, There is a lack of documentation concerning blank lines in the texinfo source, in particular concerning their effect with the various output formats. In the GNU Texinfo 7.1.1 manual, it is said that blank lines are significant for @example and @verbatim. For @itemize and @enumerate, it is re

Re: "texi2any --html --no-split" should not generate accesskey attributes

2025-05-20 Thread Patrice Dumas
On Mon, May 19, 2025 at 09:35:31PM +0100, Gavin Smith wrote: > On Tue, May 13, 2025 at 04:28:28PM +0200, Vincent Lefevre wrote: > > "texi2any --html --no-split" generates many accesskey attributes > > with the same value. This does not make sense. In particular, the > > behavior in such a case depe

Re: [PATCH] Fix an uninitialized variable.

2025-05-20 Thread Patrice Dumas
Hello, The analysis and patch look good to me. Gavin, I think that you can apply it (I know that it is a kind of patch practical for git to get both the patch and commiter right, but I don't know how to apply that kind of patch). On Mon, May 19, 2025 at 06:43:10PM -0700, Collin Funk wrote: > Hi