Re: C++ hash map usage

2024-10-19 Thread Gavin Smith
On Fri, Oct 18, 2024 at 04:14:24PM +0100, Gavin Smith wrote: > On Thu, Oct 17, 2024 at 09:31:35PM +0200, Patrice Dumas wrote: > > > > Could add the number of footnotes * 2 and the number of special units > > > > (including special units not associated to a section/node). And > > > > sections numbe

Re: gettext autoconf mismatch failure for opencsw 'old' Solaris CI

2024-10-19 Thread Gavin Smith
On Sat, Oct 19, 2024 at 10:01:19AM +0200, Patrice Dumas wrote: > On Sat, Oct 19, 2024 at 09:34:49AM +0200, Patrice Dumas wrote: > > Actually, I am also confused by the lack of AC_CONFIG_MACRO_DIR in the > > main directory, as I do not understand how autoreconf/aclocal can > > determine that gnulib

Re: gettext autoconf mismatch failure for opencsw 'old' Solaris CI

2024-10-19 Thread Gavin Smith
On Sat, Oct 19, 2024 at 09:34:49AM +0200, Patrice Dumas wrote: > On Fri, Oct 18, 2024 at 10:10:03PM +0100, Gavin Smith wrote: > > tp/Texinfo/XS/gnulib/m4/gettext.m4 was added in commit 2cd1cfc788d207c, > > (Gavin Smith, 2019-03-17), as a result of running gettextize. Some of > > the confusion may

Re: syntax error reported in maintain/generate_code_convert_data.pl

2024-10-19 Thread Patrice Dumas
On Fri, Oct 18, 2024 at 09:49:00PM +0100, Gavin Smith wrote: > /opt/csw/bin/perl ./../../maintain/generate_code_convert_data.pl \ > < ./main/command_data.c \ > ./../Data/default_css_element_class_styles.csv \ > ./../Data/default_direction_strings.csv \ >

Re: PACKAGE_VERSION and new get_build_constant interface

2024-10-19 Thread Gavin Smith
On Sat, Oct 19, 2024 at 09:09:07AM +0200, Patrice Dumas wrote: > On Fri, Oct 18, 2024 at 07:56:14PM +0100, Gavin Smith wrote: > > > > Do you think we should mention get_build_constant in NEWS? Are there > > any other changes for init files that should also be mentioned in > > NEWS? > > I think t

Re: syntax error reported in maintain/generate_code_convert_data.pl

2024-10-19 Thread Gavin Smith
On Fri, Oct 18, 2024 at 09:49:01PM +0100, Gavin Smith wrote: > The Solaris CI reports a syntax error: > ... > I guess "continue;" should have been "next;"? I have never looked at > this Perl program before and don't know what it is for. I saw you fixed this. With the other commits for gettext

Re: gettext autoconf mismatch failure for opencsw 'old' Solaris CI

2024-10-19 Thread Patrice Dumas
On Fri, Oct 18, 2024 at 08:56:24PM +0100, Gavin Smith wrote: > > Removing gettext.m4 was a mistake, as far as I can tell. > > I've attempted to revert the change although it may not be enough as > you have made other changes involving gnulib and/or gettext at the > same time. > > Another commit w

Re: gettext autoconf mismatch failure for opencsw 'old' Solaris CI

2024-10-19 Thread Patrice Dumas
On Sat, Oct 19, 2024 at 09:34:49AM +0200, Patrice Dumas wrote: > Actually, I am also confused by the lack of AC_CONFIG_MACRO_DIR in the > main directory, as I do not understand how autoreconf/aclocal can > determine that gnulib autoconf macros come from gnulib/m4. Found it, there is a -I gnulib/m4

Re: gettext autoconf mismatch failure for opencsw 'old' Solaris CI

2024-10-19 Thread Patrice Dumas
On Fri, Oct 18, 2024 at 10:10:03PM +0100, Gavin Smith wrote: > tp/Texinfo/XS/gnulib/m4/gettext.m4 was added in commit 2cd1cfc788d207c, > (Gavin Smith, 2019-03-17), as a result of running gettextize. Some of > the confusion may come from the fact that gettextize places files in > gnulib/m4 even tho

Re: gettext autoconf mismatch failure for opencsw 'old' Solaris CI

2024-10-19 Thread Patrice Dumas
On Fri, Oct 18, 2024 at 08:35:11PM +0100, Gavin Smith wrote: > On Sun, Oct 06, 2024 at 07:45:20PM +0200, Patrice Dumas wrote: > > Hello, > > > > I removed some gettext macros installed by gnulib or gettextize in 2021 > > when updating gnulib (when I updated the setup of the gnulib po > > directori

Re: PACKAGE_VERSION and new get_build_constant interface

2024-10-19 Thread Patrice Dumas
On Fri, Oct 18, 2024 at 07:56:14PM +0100, Gavin Smith wrote: > > Do you think we should mention get_build_constant in NEWS? Are there > any other changes for init files that should also be mentioned in > NEWS? I think that it is too early to mention changes in the HTML customization API in NEWS.