> From: Gavin Smith
> Date: Tue, 15 Oct 2024 22:22:45 +0100
> Cc: bug-texinfo@gnu.org
>
> I can imagine that at some point we will abandon the Perl version of
> some code, requiring XS to use texi2any.
One problem with doing that is that the distributed binaries of
Texinfo will require a very sp
On Tue, Oct 15, 2024 at 12:31:07PM +0100, Gavin Smith wrote:
> On Mon, Oct 14, 2024 at 11:16:58PM +0200, Patrice Dumas wrote:
> > This looks good to me, it is quite simple. Maybe the number of buckets
> > could be set based on the number of sections + nodes + index entries?
>
> Great idea, I was
On Tue, Oct 15, 2024 at 09:34:08PM +0100, Gavin Smith wrote:
> On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> > From f9e62115a2ae91e721021f52bdf2c76fe717a5eb Mon Sep 17 00:00:00 2001
> > From: Vitezslav Crhonek
> > Date: Tue, 15 Oct 2024 11:07:06 +0200
> > Subject: [PATCH 3/7
On Tue, Oct 15, 2024 at 10:07:24PM +0100, Gavin Smith wrote:
> On Sun, Oct 06, 2024 at 03:43:17PM +0200, Patrice Dumas wrote:
> > Hello,
> >
> > I did the timings on elisp, glibc and texinfo manuals and I get about
> > * 2 between C only and Perl with TEXINFO_XS_CONVERT=1 and
> > * 4 between Pe
On Tue, Oct 08, 2024 at 10:09:21AM -0700, Per Bothner wrote:
> On 10/8/24 9:25 AM, Gavin Smith wrote:
> > The question for me is not, "is C++ a good language". It is, "does
> > using C++ in Texinfo threaten the long-term future of the Texinfo project".
> > I can imagine a situation, hypothetically
On Sun, Oct 06, 2024 at 03:43:17PM +0200, Patrice Dumas wrote:
> Hello,
>
> I did the timings on elisp, glibc and texinfo manuals and I get about
> * 2 between C only and Perl with TEXINFO_XS_CONVERT=1 and
> * 4 between Perl with TEXINFO_XS_CONVERT=1 and Perl with XS for
> parser only.
Sorry,
On Tue, Oct 15, 2024 at 09:34:09PM +0100, Gavin Smith wrote:
> I used xasprintf (wrapper around libc function asprintf) here instead
> as it is shorter and more robust.
>
> Patrice already replied about the initialiser of 'description'. However,
> as the code currently stands, there is code that
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> From f9e62115a2ae91e721021f52bdf2c76fe717a5eb Mon Sep 17 00:00:00 2001
> From: Vitezslav Crhonek
> Date: Tue, 15 Oct 2024 11:07:06 +0200
> Subject: [PATCH 3/7] * info/session.c: add initializer, allocate memory for
> the termina
On Tue, Oct 15, 2024 at 08:11:02PM +0200, Patrice Dumas wrote:
> > diff --git a/info/util.c b/info/util.c
> > index 7ecb90f06b..a511471b9f 100644
> > --- a/info/util.c
> > +++ b/info/util.c
> > @@ -34,9 +34,12 @@ xvasprintf (char **ptr, const char *template, va_list ap)
> > int
> > xasprintf (cha
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> Hi,
>
> Please review proposed fixes of issues found by static analysis
> of texinfo-7.1 in the attached patch and consider applying them.
>
> @@ -2949,7 +2949,7 @@ DECLARE_INFO_COMMAND (info_menu_sequence,
> static int
> info
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> From 0f3a45b5b48db00e9d1d8ab6c61a4e7502966bd1 Mon Sep 17 00:00:00 2001
> From: Vitezslav Crhonek
> Date: Tue, 15 Oct 2024 12:17:32 +0200
> Subject: [PATCH 6/7] * info/infomap.c: fix resource leak
>
> ---
> info/infomap.c | 1 +
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> From aae25e4335fa4127b9c3e73486095df304ae735a Mon Sep 17 00:00:00 2001
> From: Vitezslav Crhonek
> Date: Tue, 15 Oct 2024 10:58:52 +0200
> Subject: [PATCH 2/7] * info/infokey.c: add initializer
>
> ---
> info/infokey.c | 2 +-
>
On 10/15/24 1:06 PM, Gavin Smith wrote:
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
Hi,
Please review proposed fixes of issues found by static analysis
of texinfo-7.1 in the attached patch and consider applying them.
Thanks for sending them, I would like to take some
On Mon, Oct 14, 2024 at 11:16:58PM +0200, Patrice Dumas wrote:
> This looks good to me, it is quite simple. Maybe the number of buckets
> could be set based on the number of sections + nodes + index entries?
Great idea, I was concerned that I'd hardcoded the number of buckets.
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> Hi,
>
> Please review proposed fixes of issues found by static analysis
> of texinfo-7.1 in the attached patch and consider applying them.
>
> During the investigation I stumbled on this chunk of code
> in install-info.c (starti
On Tue, Oct 15, 2024 at 12:36:59PM +0200, Vitezslav Crhonek wrote:
> Hi,
>
> Please review proposed fixes of issues found by static analysis
> of texinfo-7.1 in the attached patch and consider applying them.
Thanks for sending them, I would like to take some time to look
at and understand them.
Hi,
Please review proposed fixes of issues found by static analysis
of texinfo-7.1 in the attached patch and consider applying them.
During the investigation I stumbled on this chunk of code
in install-info.c (starting by line 831):
if (fclose (f) < 0)
return 0;
f2 = freopen
17 matches
Mail list logo
