Re: strange build failure for cygwin32 in CI

2024-10-10 Thread Eli Zaretskii
-Xlinker > .libs/libtexinfoxs.dll.a > > However this does not work better. I still get errors like: > /usr/lib/gcc/i686-pc-cygwin/11/../../../../i686-pc-cygwin/bin/ld: > main/.libs/libtexinfoxs_la-build_perl_info.o: in function > `element_to_perl_hash': > /cygdrive/d/a

Re: strange build failure for cygwin32 in CI

2024-10-10 Thread Patrice Dumas
s-0.dll -Wl,--enable-auto-image-base -Xlinker --out-implib -Xlinker .libs/libtexinfoxs.dll.a However this does not work better. I still get errors like: /usr/lib/gcc/i686-pc-cygwin/11/../../../../i686-pc-cygwin/bin/ld: main/.libs/libtexinfoxs_la-build_perl_info.o: in function `element_

Re: Make CHECK_HTMLXREF on by default

2024-10-10 Thread Patrice Dumas
On Thu, Oct 10, 2024 at 07:38:39PM +0100, Gavin Smith wrote: > On Sun, Aug 25, 2024 at 02:13:07PM +0200, Patrice Dumas wrote: > > > > This is already possible, it is CHECK_HTMLXREF (which is set to 1 in the > > > > default case for EPUB as relative paths in EPUB are not possible). > > > > > > Good

Re: separate information from variable value for window goal_column

2024-10-10 Thread Patrice Dumas
On Thu, Oct 10, 2024 at 04:29:21PM +0100, Gavin Smith wrote: > > I propose in the patch to separate the information set by -1 from the > > goal_column value, by setting this information in the window->flags > > separately from the goal_column. This is for two reasons, first I think > > that using

Make CHECK_HTMLXREF on by default

2024-10-10 Thread Gavin Smith
On Sun, Aug 25, 2024 at 02:13:07PM +0200, Patrice Dumas wrote: > > > This is already possible, it is CHECK_HTMLXREF (which is set to 1 in the > > > default case for EPUB as relative paths in EPUB are not possible). > > > > Good point. I think we should make CHECK_HTMLXREF=1 the default for > > HT

Re: -Wtype-limits warning in info/infokey.c

2024-10-10 Thread Andreas Schwab
On Okt 10 2024, Eli Zaretskii wrote: > I think we should declare 'oval' as 'int' instead. The octal case also needs a better range check, so that \777 is not parsed as 511. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now

Re: -Wtype-limits warning in info/infokey.c

2024-10-10 Thread Gavin Smith
On Thu, Oct 10, 2024 at 02:22:52PM +0300, Eli Zaretskii wrote: > > Date: Thu, 10 Oct 2024 12:33:45 +0200 > > From: Patrice Dumas > > > > Hello, > > > > I get this warning: > > In file included from ../../info/doc.h:59, > > from ../../info/infokey.c:21: > > ../../info/infokey.c:

Re: add missing initializers?

2024-10-10 Thread Gavin Smith
On Thu, Oct 10, 2024 at 09:00:32AM +0200, Patrice Dumas wrote: > Hello, > > There are warnings with -Wmissing-field-initializers for info/variables.c > VARIABLE_ALIST info_variables where the where_set field is never > explicitely set. This code is from Gavin, and is by design, as there > is this

Re: separate information from variable value for window goal_column

2024-10-10 Thread Gavin Smith
On Wed, Oct 09, 2024 at 08:00:42PM +0200, Patrice Dumas wrote: > Hello, > > Here is a patch that I would like to propose, but it could be > controversial so I prefer to ask here first. This is in info code, > currently window->goal_column is set to -1 to mean that the > column to place the cursor

Re: -Wtype-limits warning in info/infokey.c

2024-10-10 Thread Eli Zaretskii
> Date: Thu, 10 Oct 2024 12:33:45 +0200 > From: Patrice Dumas > > Hello, > > I get this warning: > In file included from ../../info/doc.h:59, > from ../../info/infokey.c:21: > ../../info/infokey.c: In function ‘compile’: > ../../info/infomap.h:105:29: warning: comparison is alwa

-Wtype-limits warning in info/infokey.c

2024-10-10 Thread Patrice Dumas
Hello, I get this warning: In file included from ../../info/doc.h:59, from ../../info/infokey.c:21: ../../info/infokey.c: In function ‘compile’: ../../info/infomap.h:105:29: warning: comparison is always true due to limited range of data type [-Wtype-limits] 105 | #define KEYMA

add missing initializers?

2024-10-10 Thread Patrice Dumas
Hello, There are warnings with -Wmissing-field-initializers for info/variables.c VARIABLE_ALIST info_variables where the where_set field is never explicitely set. This code is from Gavin, and is by design, as there is this comment: /* Note that the 'where_set' field of each element in the array i