ffmpeg documentation no longer builds after Texinfo 7.1 (due to --init-file=)

2023-11-04 Thread Arsen Arsenović
Afternoon, Following changes in Texinfo 7.1 (uncertain which commit - haven't bisected) FFmpeg documentation no longer builds. This is due to an init file (attached). The following is a minimum reproducer: makeinfo --init-file=t2h.pm -o /dev/null /dev/null The result: makeinfo: error pars

Re: Post release texi2any performance regression

2023-11-04 Thread Gavin Smith
On Sat, Nov 04, 2023 at 04:06:06PM +, Gavin Smith wrote: > > > Applying this patch slows the program down by about 3% now. However, > > > it could still be useful for investigating why development texi2any is > > > still significantly slower (about 5%) than texi2any 7.1. It seems that > > > e

Code from installed libtexinfo.so.0 run for non-installed texi2any

2023-11-04 Thread Gavin Smith
I have just had a frustrating time trying to work out why none of the changes I was making to the parsetexi module were taking effect. For example, the same debugging messages were still being printed even though I had effaced all instances of them from the source code. I suspected that installed

Re: Post release texi2any performance regression

2023-11-04 Thread Gavin Smith
On Sat, Nov 04, 2023 at 04:06:06PM +, Gavin Smith wrote: > > To me the most likely reason would be that simple_parser has been > > removed, such that calls of gdt/pgdt from perl are slower. > > Thanks, I'll try to investigate this. This is very significant for TEXINFO_XS=omit but makes no dif

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-04 Thread Sam James
Gavin Smith writes: > On Sat, Nov 04, 2023 at 01:10:47PM +, Sam James wrote: >> >> John Paul Adrian Glaubitz writes: >> >> > Hi Gavin! >> > >> > On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: >> >> The line in question is: >> >> >> >> memcpy (targets, list_of_labels, labels_num

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-04 Thread Gavin Smith
On Sat, Nov 04, 2023 at 01:10:47PM +, Sam James wrote: > > John Paul Adrian Glaubitz writes: > > > Hi Gavin! > > > > On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: > >> The line in question is: > >> > >> memcpy (targets, list_of_labels, labels_number * sizeof(LABEL)); > >> > >> -

Re: Post release texi2any performance regression

2023-11-04 Thread Gavin Smith
On Sat, Nov 04, 2023 at 02:50:36PM +0100, Patrice Dumas wrote: > On Sat, Nov 04, 2023 at 01:18:58PM +, Gavin Smith wrote: > > On Sat, Oct 28, 2023 at 05:42:51PM +0100, Gavin Smith wrote: > > > I managed to disable a lot of the new XS code and get the test suite > > > to pass. I had to leave th

Re: Post release texi2any performance regression

2023-11-04 Thread Patrice Dumas
On Sat, Nov 04, 2023 at 01:18:58PM +, Gavin Smith wrote: > On Sat, Oct 28, 2023 at 05:42:51PM +0100, Gavin Smith wrote: > > I managed to disable a lot of the new XS code and get the test suite > > to pass. I had to leave the XS translation module active due to the > > coupling that now exists

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-04 Thread Sam James
Sam James writes: > John Paul Adrian Glaubitz writes: > >> Hi Gavin! >> >> On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: >>> The line in question is: >>> >>> memcpy (targets, list_of_labels, labels_number * sizeof(LABEL)); >>> >>> - again, the second argument of memcpy. >>> >>> Ho

Re: Post release texi2any performance regression

2023-11-04 Thread Gavin Smith
On Sat, Oct 28, 2023 at 05:42:51PM +0100, Gavin Smith wrote: > I managed to disable a lot of the new XS code and get the test suite > to pass. I had to leave the XS translation module active due to the > coupling that now exists between it and the XS parser. This patch wasn't working any more so

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-04 Thread Sam James
John Paul Adrian Glaubitz writes: > Hi Gavin! > > On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: >> The line in question is: >> >> memcpy (targets, list_of_labels, labels_number * sizeof(LABEL)); >> >> - again, the second argument of memcpy. >> >> However, main/targets.c was only in

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-04 Thread John Paul Adrian Glaubitz
Hi Gavin! On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: > The line in question is: > > memcpy (targets, list_of_labels, labels_number * sizeof(LABEL)); > > - again, the second argument of memcpy. > > However, main/targets.c was only introduced after Texinfo 7.1 so > this is not the or

set_labels_identifiers_target -fsanitize=undefined error

2023-11-04 Thread Gavin Smith
On Wed, Nov 01, 2023 at 03:44:01PM +, Sam James wrote: > > John Paul Adrian Glaubitz writes: > > > Hello! > > > > Starting with texinfo 7.1, there is a regression that results in texi2any > > crashing with a Bus Error on SPARC running on Linux [1]: > > > > /bin/bash: line 16: 753042 Bus erro

Re: [7.1] texi2any crashes with Bus Error on SPARC

2023-11-04 Thread Gavin Smith
On Wed, Nov 01, 2023 at 03:44:01PM +, Sam James wrote: > I thought I'd take a quick look at this. When I tried building with > -fsanitize=undefined on amd64, unfortunately, I hit another issue > immediately (with export UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=1):: > > util.c:380:3: runt