Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Arash Esbati
Gavin Smith writes: > Thanks for sending these. I've committed it. Thanks for installing it, and thanks for fixing all the other issues. I see that Texinfo doesn't have any instructions how to build and install Texinfo with MinGW64. Should I make a proposal? Best, Arash

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Gavin Smith
On Wed, Apr 05, 2023 at 09:46:28AM +0200, Arash Esbati wrote: > Hi all, > > I tried Eli's advice in this message[1] reg. silencing of compiler > warnings about "free" redefined. The change below made them go away: Thanks for sending these. I've committed it. We already had this in some files (

Re: integer types

2023-04-05 Thread Andreas Schwab
On Apr 05 2023, Eli Zaretskii wrote: > If the pointer is to a narrower type, then dereferencing it will take > only part of the bits of the integer value. Depending on the > endianness, that part could be the LSB (good) or MSB (bad). A conversion operates on the value, not representation, so end

Re: integer types

2023-04-05 Thread Gavin Smith
On Wed, Apr 05, 2023 at 05:14:03PM +0300, Eli Zaretskii wrote: > > From: Gavin Smith > > Date: Wed, 5 Apr 2023 14:59:23 +0100 > > Cc: pertu...@free.fr, ar...@gnu.org, bug-texinfo@gnu.org > > > > Might it be better to round-trip through intptr_t rather than through > > a pointer type? > > Yes, I

Re: integer types

2023-04-05 Thread Eli Zaretskii
> From: Gavin Smith > Date: Wed, 5 Apr 2023 14:59:23 +0100 > Cc: pertu...@free.fr, ar...@gnu.org, bug-texinfo@gnu.org > > Might it be better to round-trip through intptr_t rather than through > a pointer type? Yes, I think this will be better. Cleaner, too. > > I think you are forgetting the e

Re: integer types

2023-04-05 Thread Gavin Smith
On Wed, Apr 05, 2023 at 02:50:36PM +0300, Eli Zaretskii wrote: > > We don't need to make changes to stop these warnings if it is going > > to be difficult to do so. > > But is it, in fact, difficult? Are there any problems with using > intptr_t, or (if we fear of it being unsupported on some plat

Re: [PATCH] install-info: fix delete dir file section code

2023-04-05 Thread John Wheeler
On 3/26/23 13:28, John Wheeler wrote: Attached is a revised patch that addresses your concern.  With this patch deleting a section will remove all preceding blank lines.  This change required changing file ii-0047-expected-dir-file to remove the extra blank line at the end of the file. I added

Re: integer types

2023-04-05 Thread Eli Zaretskii
> From: Gavin Smith > Date: Wed, 5 Apr 2023 12:24:58 +0100 > Cc: Patrice Dumas , ar...@gnu.org, bug-texinfo@gnu.org > > GNU coding standards (Info node (standards)CPU Portability): > > You need not cater to the possibility that 'long' will be smaller > than pointers and 'size_t'. We know

integer types

2023-04-05 Thread Gavin Smith
On Wed, Apr 05, 2023 at 01:08:41PM +0300, Eli Zaretskii wrote: > > Date: Wed, 5 Apr 2023 11:31:12 +0200 > > From: Patrice Dumas > > Cc: Arash Esbati , bug-texinfo@gnu.org > > > > On Wed, Apr 05, 2023 at 11:47:08AM +0300, Eli Zaretskii wrote: > > > Those are real bugs: we should cast to inptr_t in

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Eli Zaretskii
> Date: Wed, 5 Apr 2023 11:31:12 +0200 > From: Patrice Dumas > Cc: Arash Esbati , bug-texinfo@gnu.org > > On Wed, Apr 05, 2023 at 11:47:08AM +0300, Eli Zaretskii wrote: > > Those are real bugs: we should cast to inptr_t instead of long. > > We already do that in some code, but we immediatly cast

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Patrice Dumas
On Wed, Apr 05, 2023 at 11:47:08AM +0300, Eli Zaretskii wrote: > Those are real bugs: we should cast to inptr_t instead of long. We already do that in some code, but we immediatly cast to another type, defined in perl, like IV value = (IV) (intptr_t) k->value; Is there a integer type we could c

Re: [PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Eli Zaretskii
> From: Arash Esbati > Date: Wed, 05 Apr 2023 09:46:28 +0200 > > The only other warnings I get are (linebreaks added manually): > > --8<---cut here---start->8--- > parsetexi/handle_commands.c: In function 'handle_other_command': > parsetexi/handle_commands.c:3

[PATCH] Silence compiler warnings with MinGW64

2023-04-05 Thread Arash Esbati
Hi all, I tried Eli's advice in this message[1] reg. silencing of compiler warnings about "free" redefined. The change below made them go away: --8<---cut here---start->8--- diff --git a/tp/Texinfo/XS/MiscXS.xs b/tp/Texinfo/XS/MiscXS.xs index a8c58cc539..65b6e