Re: [PATCH] Warn user when 2 files conflict on a case insensitive fs

2023-01-09 Thread Patrice Dumas
On Mon, Jan 09, 2023 at 08:00:38PM +0100, Torbjorn SVENSSON wrote: > > > Feel free to do it if you have time right now for it or I can try to take a > stab at it in a few days. Actually it is probably better if I do it in any case, as gathering which command lead to a given file name is gonna be

Re: texinfo-7.0.1 on OpenSolaris

2023-01-09 Thread Gavin Smith
On Wed, Jan 04, 2023 at 08:02:12PM +, Gavin Smith wrote: > I've committed the change to the master branch. I will add it to the > release branch if there is no further feedback. I've added the fixes for building on Solaris to the release/7.0 branch now.

Re: report a warning

2023-01-09 Thread Gavin Smith
On Mon, Jan 09, 2023 at 08:39:44PM +0100, Hans-Bernhard Bröker wrote: > > Whatever the original intention was behind strncat, this seems like > > a reasonable way to use strncat based on its behaviour and documentation. > > It is not. > > The size argument exists to enable the caller to make sure

Re: report a warning

2023-01-09 Thread Hans-Bernhard Bröker
Am 09.01.2023 um 19:58 schrieb Gavin Smith: As I said in another message, it appears that everywhere strncat is used, the length argument is used for the number of bytes to copy in the source buffer, not for the size remaining in the destination buffer. And that is at least superficially wrong

Re: [PATCH] Warn user when 2 files conflict on a case insensitive fs

2023-01-09 Thread Torbjorn SVENSSON
On 2023-01-09 19:32, Patrice Dumas wrote: On Mon, Jan 09, 2023 at 09:57:45AM +0100, Patrice Dumas wrote: Actually, it could be that redirection pages clash with element file names because of transliteration, for example the following names would clash: @node Près @anchor{Prés} It is indeed

Re: report a warning

2023-01-09 Thread Gavin Smith
On Mon, Jan 09, 2023 at 07:35:42PM +0100, Hans-Bernhard Bröker wrote: > It's not. It warns about a practice that has often been used to avoid > another warning, while not actually achieving any improvement. > > In a nutshell, strcat() itself has long since been frowned upon as a highly > likely s

Re: report a warning

2023-01-09 Thread Hans-Bernhard Bröker
Am 09.01.2023 um 18:44 schrieb Gavin Smith: There have long been compiler warnings about the use of strncat in install-info.c but there isn't any indication that the code is actually incorrect. This compiler warning seems to be completely bogus. It's not. It warns about a practice that has

Re: [PATCH] Warn user when 2 files conflict on a case insensitive fs

2023-01-09 Thread Patrice Dumas
On Mon, Jan 09, 2023 at 09:57:45AM +0100, Patrice Dumas wrote: > > Actually, it could be that redirection pages clash with element file > names because of transliteration, for example the following names would > clash: > @node Près > @anchor{Prés} It is indeed the case, I added a test case that d

Re: report a warning

2023-01-09 Thread Gavin Smith
On Mon, Jan 09, 2023 at 05:44:05PM +, Gavin Smith wrote: > There have long been compiler warnings about the use of strncat in > install-info.c but there isn't any indication that the code is actually > incorrect. This compiler warning seems to be completely bogus. The > real way the code coul

Re: report a warning

2023-01-09 Thread Gavin Smith
On Sat, Jan 07, 2023 at 04:53:38PM +0330, Faezeh Bidjarchian wrote: > Hi > > I install the latest version of texinfo (texinfo-7.0.1) and found this > warning: > > gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../gnulib/lib -I../gnulib/lib > -DLOCALEDIR=\"/usr/local/share/locale\" -g -O2 -MT install-info

Re: [PATCH] Warn user when 2 files conflict on a case insensitive fs

2023-01-09 Thread Patrice Dumas
On Mon, Jan 09, 2023 at 08:03:52AM +0100, Torbjorn SVENSSON wrote: > > > On 2023-01-07 16:05, Patrice Dumas wrote: > > That'd be nice, indeed. Beware that the issue can happen between > > redirection pages, and also between regular elements and redirection > > pages (but not between regular elem