Re: ShellCheck reports error in run_parser_all.sh (patch)

2021-02-16 Thread Vitezslav Crhonek
On 2/16/21 5:00 PM, Gavin Smith wrote: > On Tue, Feb 16, 2021 at 10:30:44AM +0100, Vitezslav Crhonek wrote: >> Hi, >> >> ShellCheck reports error [1] in tp/tests/run_parser_all.sh script. >> 'continue' is used there to exit a function. >> >> I don't consider it to be a big deal but it would be nice

Re: upcoming pretest release

2021-02-16 Thread Per Bothner
On 2/16/21 1:40 PM, Gavin Smith wrote: I'm getting very close to building and uploading a pretest release, although I am sure that there is still more to be done. Please think if there is anything that desparately needs to be done (i.e. stuff that is clearly broken), avoiding large changes if po

Re: parsetexi warnings

2021-02-16 Thread Per Bothner
On 2/16/21 2:39 PM, Gavin Smith wrote: It's the C version of the Texinfo::Parser module. I will look at the warnings (I think most of them were due to ignoring the return value of asprintf). I see a lot of warnings - see attachment (edited down compile log). Most but not all from parsetexi. I

Re: parsetexi warnings

2021-02-16 Thread Gavin Smith
On Tue, Feb 16, 2021 at 02:18:45PM -0800, Per Bothner wrote: > What is parsetexi used for? Doing a 'make' emits a > lot of compiler warnings in parsetexi. > If it is experimental or no longer used, perhaps > it should not be built by default - i.e. it should > only be built if --enable-parsetexi i

Re: js-info contents page [patch]

2021-02-16 Thread Gavin Smith
On Tue, Feb 16, 2021 at 02:22:11PM -0800, Per Bothner wrote: > Ok to check in? > >     * js/info.js: Fix [Contents] link by creating a fresh page-node for the > ToC. >     This is done by cloning the ToC from the index.html.  Cloning is needed > because >     the same table is used for the

Re: parsetexi warnings

2021-02-16 Thread Patrice Dumas
On Tue, Feb 16, 2021 at 02:18:45PM -0800, Per Bothner wrote: > What is parsetexi used for? Doing a 'make' emits a > lot of compiler warnings in parsetexi. > If it is experimental or no longer used, perhaps > it should not be built by default - i.e. it should > only be built if --enable-parsetexi i

Re: js-info contents page [patch]

2021-02-16 Thread Per Bothner
Ok to check in?     * js/info.js: Fix [Contents] link by creating a fresh page-node for the ToC.     This is done by cloning the ToC from the index.html.  Cloning is needed because     the same table is used for the Sidebar. -- --Per Bothner p...@bothner.com http://per.bothner.

parsetexi warnings

2021-02-16 Thread Per Bothner
What is parsetexi used for? Doing a 'make' emits a lot of compiler warnings in parsetexi. If it is experimental or no longer used, perhaps it should not be built by default - i.e. it should only be built if --enable-parsetexi is specified to configure. If it is something that should be built by d

upcoming pretest release

2021-02-16 Thread Gavin Smith
I'm getting very close to building and uploading a pretest release, although I am sure that there is still more to be done. Please think if there is anything that desparately needs to be done (i.e. stuff that is clearly broken), avoiding large changes if possible.

Re: ShellCheck reports error in run_parser_all.sh (patch)

2021-02-16 Thread Gavin Smith
On Tue, Feb 16, 2021 at 10:30:44AM +0100, Vitezslav Crhonek wrote: > Hi, > > ShellCheck reports error [1] in tp/tests/run_parser_all.sh script. > 'continue' is used there to exit a function. > > I don't consider it to be a big deal but it would be nice to have it > fixed at least for the sake of

ShellCheck reports error in run_parser_all.sh (patch)

2021-02-16 Thread Vitezslav Crhonek
Hi, ShellCheck reports error [1] in tp/tests/run_parser_all.sh script. 'continue' is used there to exit a function. I don't consider it to be a big deal but it would be nice to have it fixed at least for the sake of clean code. Simple patch attached. The issue has been originally reported by yea

Re: html structure revisited

2021-02-16 Thread Patrice Dumas
On Mon, Feb 15, 2021 at 01:28:46PM -0800, Per Bothner wrote: > On 2/15/21 5:41 AM, Patrice Dumas wrote: > > Hello, > > > > I had a look at the result when there is no node, with a document like > > Note the patch in your reply, which probably was a reply to this: > > https://lists.gnu.org/archiv