Re: [patch] fix out of bounds memory read in forward_to_info_syntax() / info-utils.c

2016-07-10 Thread Hanno Böck
On Sun, 10 Jul 2016 19:57:31 +0100 Gavin Smith wrote: > means that the condition will be true whenever a null byte is reached, > rather when the three bytes "\0\b[" are reached. This is because > strncmp has a weaker condition for equality than memcmp, in that > anything after null bytes is ignor

Re: [patch] fix out of bounds memory read in forward_to_info_syntax() / info-utils.c

2016-07-10 Thread Gavin Smith
On 10 July 2016 at 11:47, Hanno Böck wrote: > Hi, > > There is an out of bounds invalid memory read in the function > forward_to_info_syntax(). > > This is the code (info-utils.c): > if (looking_at_string (contents, INFO_MENU_ENTRY_LABEL) > || looking_at_string (contents, INFO_XREF

Re: @-commands in @errormsg

2016-07-10 Thread Norbert Preining
Hi Gavin, > be output the same as before. It wouldn't stop documentation from > building if it worked before. That is *very* good. > I like the idea of testing all the Texinfo documents in Debian; is > there some easy way of getting them all? I will look into getting most of them. Give me some

[patch] fix out of bounds memory read in forward_to_info_syntax() / info-utils.c

2016-07-10 Thread Hanno Böck
Hi, There is an out of bounds invalid memory read in the function forward_to_info_syntax(). This is the code (info-utils.c): if (looking_at_string (contents, INFO_MENU_ENTRY_LABEL) || looking_at_string (contents, INFO_XREF_LABEL) || !memcmp (contents, "\0\b[", 3)) The p