Re: HAVE_MSVC_INVALID_PARAMETER_HANDLER test unquoted

2016-01-02 Thread Paul Eggert
Karl Berry wrote: I don't know if it's supposed to be guaranteed to be set, but if so, evidently that guarantee is failing. Yes, it is supposed to be set. Let's fix that bug, which is the real problem; quoting $HAVE_MSVC_INVALID_PARAMETER_HANDLER would merely suppress the warning. I installed

HAVE_MSVC_INVALID_PARAMETER_HANDLER test unquoted

2016-01-02 Thread Karl Berry
Gnulib people - Eli Z reported seeing this familiar shell diagnostic with the current Texinfo configure: ./configure: line 22339: test: =: unary operator expected That line turns out to be: if test $HAVE_MSVC_INVALID_PARAMETER_HANDLER = 1; then And looking at gnulib/m4, indeed that variable

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Andreas Schwab
Gavin Smith writes: > I don't see why it's a problem. Anything that is installed but unused is bad. > Installing it in some other directory wouldn't help either. No, you never run make install in that directory. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Andreas Schwab
Gavin Smith writes: > I wonder what's gone wrong. The (unexecuted) AC_SUBST in gl_CONFIGMAKE_PREP overrides automake's definition. A bad gnulib bug. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for somethi

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 20:58, Andreas Schwab wrote: > Gavin Smith writes: > >> I've remembered that if you don't specify an installation directory >> for a Libtool library, some of the Makefile rules aren't generated >> properly. I can't remember the details but I thought it was a bug in >> Libtool

Re: luatex problems with texinfo.tex

2016-01-02 Thread Werner LEMBERG
>>> Thanks for working on this. This patch uses native LuaTeX support >>> for Unicode. If we wanted to support this in texinfo.tex, it should >>> probably be optional. >> >> Rather not. > > Why not? What about the reasons Karl mentioned for defaulting to > bytewise input (assuming we find some way

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Andreas Schwab
Gavin Smith writes: > I've remembered that if you don't specify an installation directory > for a Libtool library, some of the Makefile rules aren't generated > properly. I can't remember the details but I thought it was a bug in > Libtool at the time. A uninstalled libtool library is only built

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 20:14, Andreas Schwab wrote: > tp/Makefile.am uses @pkglibexecdir@, but pkglibexecdir is never > AC_SUBSTed (it is only set if either mbrtowc or wcwidth are unavailable > or must be replaced). I checked tp/Makefile and there's the following: pkglibexecdir = No, that doesn't

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Andreas Schwab
tp/Makefile.am uses @pkglibexecdir@, but pkglibexecdir is never AC_SUBSTed (it is only set if either mbrtowc or wcwidth are unavailable or must be replaced). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for so

Re: luatex problems with texinfo.tex

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 19:24, Werner LEMBERG wrote: > >>> I've made attached quick hack patch for texinfo.tex. The >>> following command [to compile the lilypond documentation] does >>> not occur `Undefined control sequence.' with the patch. >> >> Thanks for working on this. This patch uses

Re: luatex problems with texinfo.tex

2016-01-02 Thread Werner LEMBERG
>> I've made attached quick hack patch for texinfo.tex. The >> following command [to compile the lilypond documentation] does >> not occur `Undefined control sequence.' with the patch. > > Thanks for working on this. This patch uses native LuaTeX support > for Unicode. If we wanted to su

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Sat, 2 Jan 2016 17:57:23 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 09:44, Eli Zaretskii wrote: > > Also, "make install" seems to install the TestXS shared library as > > well -- is that intended? > > I've remembered that if you don't specify an installation direc

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 09:44, Eli Zaretskii wrote: > Also, "make install" seems to install the TestXS shared library as > well -- is that intended? I've remembered that if you don't specify an installation directory for a Libtool library, some of the Makefile rules aren't generated properly. I can'

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Ken Brown
On 1/2/2016 8:53 AM, Eli Zaretskii wrote: Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org From: Ken Brown Date: Sat, 2 Jan 2016 08:31:26 -0500 -XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module $(PERL_CONF_cccdlflags) +XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module $

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > From: Ken Brown > Date: Sat, 2 Jan 2016 08:31:26 -0500 > > >> -XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module > >> $(PERL_CONF_cccdlflags) > >> +XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module > >> $(PERL_CONF_cccdlf

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Ken Brown
On 1/2/2016 3:07 AM, Eli Zaretskii wrote: Cc: bug-texinfo@gnu.org From: Ken Brown Date: Fri, 1 Jan 2016 17:45:28 -0500 There is a similar linking problem on Cygwin, but the following patch fixes it: Index: tp/Texinfo/Convert/XSParagraph/Makefile.am =

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Sat, 2 Jan 2016 12:09:01 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 11:26, Eli Zaretskii wrote: > > > > One way is to run the output through Sed, before comparing, to replace > > "^htmlxref" with "./htmlxref". > > > > That's a good suggestion, and in fact looking

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 11:26, Eli Zaretskii wrote: > > One way is to run the output through Sed, before comparing, to replace > "^htmlxref" with "./htmlxref". > That's a good suggestion, and in fact looking at the code this is done already for other tests. Below is what I came up with. If this wor

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Sat, 2 Jan 2016 10:45:39 + > From: Gavin Smith > Cc: Texinfo > > > diff --strip-trailing-cr -a -u -r > > .//diffs/staging_res/htmlxref_nodes/test_refs.2 > > .//out_parser/htmlxref_nodes/test_refs.2 > > --- .//diffs/staging_res/htmlxref_nodes/test_refs.2 2014-12-19 >

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Sat, 2 Jan 2016 10:05:22 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 09:44, Eli Zaretskii wrote: > > I applied the latest changes from the repository, and the crashes are > > gone! > > Awesome. I agree. > > The test suite passes as well -- with a single exception

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 09:44, Eli Zaretskii wrote: > The failures in htmlxref tests are due to a formatting issue. The > diffs look like this: > > diff --strip-trailing-cr -a -u -r > .//diffs/staging_res/htmlxref_nodes/test_refs.2 > .//out_parser/htmlxref_nodes/test_refs.2 > --- .//diff

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Sat, 2 Jan 2016 10:07:11 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 09:58, Eli Zaretskii wrote: > > Another minor nit is that the *.la files are also installed, although > > I'm quite sure they will never be used. This is a libtool thing, I'm > > not sure there's

Re: luatex problems with texinfo.tex

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 06:20, Werner LEMBERG wrote: >> I agree it should be skipped. >> >> In some ideal world, but in this world, I think doing so would lead >> to huge problems. For the present, it seems far more feasible to me >> to keep using the UTF-8 code in texinfo.tex for the immediate

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 09:58, Eli Zaretskii wrote: > Another minor nit is that the *.la files are also installed, although > I'm quite sure they will never be used. This is a libtool thing, I'm > not sure there's a way to avoid that easily. They are needed because the Perl code to load the module

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Gavin Smith
On 2 January 2016 at 09:44, Eli Zaretskii wrote: > I applied the latest changes from the repository, and the crashes are > gone! Awesome. > A few observations and issues with the rest of the build: > > "make install" installs the XSParagraph shared libraries into > ${prefix}/libexec/texinfo -- i

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Sat, 02 Jan 2016 11:44:35 +0200 > From: Eli Zaretskii > Cc: bug-texinfo@gnu.org > > "make install" installs the XSParagraph shared libraries into > ${prefix}/libexec/texinfo -- is that the correct place? Will Perl > find these modules when texi2any runs it? > > Also, "make install" seem

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Date: Fri, 1 Jan 2016 21:23:28 + > From: Gavin Smith > Cc: Texinfo > > On 1 January 2016 at 21:19, Eli Zaretskii wrote: > >> No Perl header files are included in text.c. > > > > Why can't we include Perl headers there? > > No reason. If the latest change I committed doesn't work, it's wo

Re: texinfo-6.0.91 pretest

2016-01-02 Thread Eli Zaretskii
> Cc: bug-texinfo@gnu.org > From: Ken Brown > Date: Fri, 1 Jan 2016 17:45:28 -0500 > > There is a similar linking problem on Cygwin, but the following patch fixes > it: > > Index: tp/Texinfo/Convert/XSParagraph/Makefile.am > === >