Re: PATCH: stack overflow on large dependency set

2002-10-09 Thread Paul D. Smith
%% Wil Evers <[EMAIL PROTECTED]> writes: >> I don't think I'll use this exact patch, since putting 0x3 >> chars on the stack doesn't seem like a good idea... plus the chance >> that a rule needs 0x1 chars for its prerequisites list seems >> very small to me. we> Well, the exac

Re: PATCH: stack overflow on large dependency set

2002-10-09 Thread Wil Evers
Hi, Paul D. Smith wrote: > I don't think I'll use this exact patch, since putting 0x3 chars on > the stack doesn't seem like a good idea... plus the chance that a rule > needs 0x1 chars for its prerequisites list seems very small to me. Well, the exact amount allocated on the stack is

Re: PATCH: stack overflow on large dependency set

2002-10-09 Thread Paul D. Smith
I don't think I'll use this exact patch, since putting 0x3 chars on the stack doesn't seem like a good idea... plus the chance that a rule needs 0x1 chars for its prerequisites list seems very small to me. But I'll do something so that this function doesn't use alloca() and fail with larg

PATCH: stack overflow on large dependency set

2002-10-09 Thread Wil Evers
Hi, The attached patch against make-3.80 fixes a mysterious segfault that occurred when I tried to regenerate a file that dependend on a lot of other files. The total length of these prerequisite filenames was somewhat more than 1MB. As it turns out, the use of alloca() for such a large data