> Date: Thu, 06 Feb 2014 16:36:52 +0200
> From: Eli Zaretskii
> Cc: bug-make@gnu.org
>
> > From: "Gisle Vanem"
> > Date: Thu, 6 Feb 2014 14:30:41 +0100
> >
> > "Eli Zaretskii" wrote:
> >
> > > Wouldn't it be better to display the error only if CreateProcess fails
> > > with e=87 _and_ the env
> From: "Gisle Vanem"
> Date: Thu, 6 Feb 2014 14:30:41 +0100
>
> "Eli Zaretskii" wrote:
>
> > Wouldn't it be better to display the error only if CreateProcess fails
> > with e=87 _and_ the environment is larger than 32KB? That would allow
> > us to avoid calling GetVersionEx, which MS wants to
"Eli Zaretskii" wrote:
Wouldn't it be better to display the error only if CreateProcess fails
with e=87 _and_ the environment is larger than 32KB? That would allow
us to avoid calling GetVersionEx, which MS wants to deprecate (see
http://msdn.microsoft.com/en-us/library/windows/desktop/ms72445
"Gisle Vanem" wrote:
My revised patch doesn't use GetVersionEx(). Attached.
I forgot the patch for proc.h:
diff --git a/w32/subproc/proc.h b/w32/subproc/proc.h
index 62ebf65..ed8d3d4 100644
--- a/w32/subproc/proc.h
+++ b/w32/subproc/proc.h
@@ -24,6 +24,6 @@ typedef int bool_t;
#define E_NO_M
> Would you like to write a modified patch along these lines?
Okay, will do.
Done. Output in this case is now something like:
process_begin: CreateProcess(g:\MingW32\msys\bin\echo.exe, echo "Generating
..", ...) failed.
CreateProcess probably failed due to a too large environment. Env-size
> From: "Gisle Vanem"
> Date: Sun, 2 Feb 2014 18:34:49 +0100
>
> "Eli Zaretskii" wrote:
>
> > Wouldn't it be better to display the error only if CreateProcess fails
> > with e=87 _and_ the environment is larger than 32KB? That would allow
> > us to avoid calling GetVersionEx, which MS wants to
"Eli Zaretskii" wrote:
Wouldn't it be better to display the error only if CreateProcess fails
with e=87 _and_ the environment is larger than 32KB? That would allow
us to avoid calling GetVersionEx, which MS wants to deprecate (see
http://msdn.microsoft.com/en-us/library/windows/desktop/ms72445
> From: "Gisle Vanem"
> Date: Sun, 2 Feb 2014 15:06:23 +0100
>
> According to:
>
> http://msdn.microsoft.com/en-us/library/windows/desktop/ms682653(v=vs.85).aspx
>
> the total size of the environment is 32kByte. This has hit me several
> times in GNU-make when CreateProcess() triggers the mys
According to:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682653(v=vs.85).aspx
the total size of the environment is 32kByte. This has hit me several
times in GNU-make when CreateProcess() triggers the mysterious error
87 (ERROR_INVALID_PARAMETER). Like in a very simple rule that in
