Re: Crash on Windows when SHELL is assigned

2017-06-06 Thread Eli Zaretskii
> From: Orgad Shaneh > Date: Tue, 6 Jun 2017 22:08:08 +0300 > Cc: bug-make@gnu.org > > > OK, I see it. Please try the patch below; if it gives satisfactory > > results, I will push it to the Make repository for the next release. > > > > --- variable.c~02016-05-21 23:22:32.0 +0300

Re: Crash on Windows when SHELL is assigned

2017-06-06 Thread Orgad Shaneh
On Tue, Jun 6, 2017 at 9:43 PM, Eli Zaretskii wrote: >> From: Orgad Shaneh >> Date: Tue, 6 Jun 2017 20:49:26 +0300 >> Cc: bug-make@gnu.org >> >> > Can you tell why this is a problem? There's no equivalent of PATHEXT >> > on Posix systems, and no one coded anything like that for Windows. Is >> >

Re: Crash on Windows when SHELL is assigned

2017-06-06 Thread Eli Zaretskii
> From: Orgad Shaneh > Date: Tue, 6 Jun 2017 20:49:26 +0300 > Cc: bug-make@gnu.org > > > Can you tell why this is a problem? There's no equivalent of PATHEXT > > on Posix systems, and no one coded anything like that for Windows. Is > > it really such a serious problem? If so, in what use cases

Re: Crash on Windows when SHELL is assigned

2017-06-06 Thread Orgad Shaneh
On Tue, Jun 6, 2017 at 8:18 PM, Eli Zaretskii wrote: >> From: Orgad Shaneh >> Date: Mon, 5 Jun 2017 23:13:26 +0300 >> >> 1 You must use a full name for SHELL, including the extension (SHELL=sh >> doesn't work. SHELL=sh.exe >> does, if sh.exe exists in PATH). PATHEXT should be used for the execu

Re: Crash on Windows when SHELL is assigned

2017-06-06 Thread Eli Zaretskii
> Date: Tue, 06 Jun 2017 20:18:45 +0300 > From: Eli Zaretskii > Cc: bug-make@gnu.org > > > 2 It looks like if PATH contains quotes, they're treated in a strange > > manner. Instead of just removing > > (unescaping) them, make looks for \"some directory in > > quotes" (observed with Process > >

Re: Crash on Windows when SHELL is assigned

2017-06-06 Thread Eli Zaretskii
> From: Orgad Shaneh > Date: Mon, 5 Jun 2017 23:13:26 +0300 > > 1 You must use a full name for SHELL, including the extension (SHELL=sh > doesn't work. SHELL=sh.exe > does, if sh.exe exists in PATH). PATHEXT should be used for the executable > detection. Can you tell why this is a problem? T

Crash on Windows when SHELL is assigned

2017-06-05 Thread Orgad Shaneh
I have 3 problems with SHELL assignment on Windows (mingw32-make): 1. You must use a full name for SHELL, including the extension (SHELL=sh doesn't work. SHELL=sh.exe does, if sh.exe exists in PATH). PATHEXT should be used for the executable detection. 2. It looks like if PATH contain