Re: Bug in update_goal_chain() logic in make 3.79.1

2001-05-09 Thread Paul D. Smith
OK, I'll look at it. However, your suggestion of moving the increment to start_waiting_job() isn't sufficient, because we only want to increment it if we actually ran something, and we don't know for sure until we get into start_job_command() whether the command is empty or not (variable expansio

Re: Bug in update_goal_chain() logic in make 3.79.1

2001-05-08 Thread Patrick J. LoPresti
"Paul D. Smith" <[EMAIL PROTECTED]> writes: > pjl> That is, when the job is being placed on the waiting chain > pjl> because the load is too high, start_job_command() is never > pjl> called. > > That's not true, though: you didn't examine what happens to those jobs > _after_ they get put o

Re: Bug in update_goal_chain() logic in make 3.79.1

2001-05-08 Thread Paul D. Smith
%% "Patrick J. LoPresti" <[EMAIL PROTECTED]> writes: pjl> I have attached a Makefile to the end of this message which pjl> illustrates this bug. I will look at the bug, but offhand your description of the code is missing something important (or, I misunderstood you). pjl> The problem is t

Bug in update_goal_chain() logic in make 3.79.1

2001-05-08 Thread Patrick J. LoPresti
I have attached a Makefile to the end of this message which illustrates this bug. Make should exit successfully when run on this Makefile, but it does not if you invoke it like this (assuming your load average is greater than zero): rm -f Makefile2 Makefile3 ; make -j 2 -l 0.0 The problem is